From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F8483B0AC1 for ; Tue, 10 Mar 2026 13:22:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148930; cv=none; b=HEDgat1WGfmcf291Lriyd3Dqs8liEMW769hdCxn5PmQbKCizGwEY4S5hVEFPWK5W7ZQKK0bcpweYMCx+x7lGoGR1hUrs9rfUjo0rEPAUpydHqC6ALucIzuPmDzL506jpXeefcFFivB3R4y3jf8G+mTXVxcECGBEoFGENiBgk/Yc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773148930; c=relaxed/simple; bh=7C48eJwQxF2SZSyojjO4eehKdtPdDBqSboD/LkVXOwA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OFAEdpp1AClATX7ryLlgtAqsPYbgAmgmV2viIYer0WUUN77SCKNsRTVfjvoFlAk6ao+NhCCedi+m1qrFoPBRe71EYDyMIbM1V33vc0DS2DS36oU6YGsnBNgGBYOd7wpUcM3gWQvg8VxEI8YepvzPu7q0rpZkaOssJr42F5HWMQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ADQQpd+b; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DLhvlaPb; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ADQQpd+b"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DLhvlaPb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773148926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5/adDEbR57gUpYJcJq84OoDVxrrM3xMPFmZCRo0jKXM=; b=ADQQpd+bpcMvyiI6BuK6I/AtlFPVjRaT1jbvm8x0bcg2sn4Mv+l/q+wGsOaa7zGZavpvJL HOw6n0NTrJxN8BVrJlzy+3Oyq/AicE10gafpjzfnHFVMImjvlOy3qRSEO7jpexZVWETsUQ RoRPrXnJkd5ZbUZ0X+x9wM3CIJYSD9c= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-pEXhFw1cPbWibpO8eneefQ-1; Tue, 10 Mar 2026 09:22:05 -0400 X-MC-Unique: pEXhFw1cPbWibpO8eneefQ-1 X-Mimecast-MFC-AGG-ID: pEXhFw1cPbWibpO8eneefQ_1773148925 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cd81506677so1375226785a.1 for ; Tue, 10 Mar 2026 06:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773148925; x=1773753725; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5/adDEbR57gUpYJcJq84OoDVxrrM3xMPFmZCRo0jKXM=; b=DLhvlaPbwaSFQKg/FmxemLJJZifDd7cIIhpxvIrZaWROKjgqKnQK81zS2r/WSu9mvZ 1x4TVLhhO06glvOYJXTBYTQHe1C/lCEECiyKmpprEGkSpnbhT/+Xy+wfN5x6paEUKxsd eleVUcWebznHZRscghpqRSurxi7A6fJyr8+SC/oFm4tth2mVEOc19JKZit9S00HY03E/ XNzQnAGkguTRFL3rrkTJWt1Ev4Xq7DVoDTHr6r9kNjeVPxV8v11X5FGr4E58NddnvLYv QUA4HTbgZjVMx4thX/P6FGMyY+HUc/G2+EnczacjtLqtmfpojjqt59bZxWNPmXy2pn5x ulpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773148925; x=1773753725; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5/adDEbR57gUpYJcJq84OoDVxrrM3xMPFmZCRo0jKXM=; b=fRfHleBjopdwYQ4w4MVuP2zTfBjQkuqYWijXZILrPTWMzhApT58obkcXTn83vKlaEF VvE4EseSQlu13b0kK+cs9p27Rxk3QcHNq4FMiaBYbFI2LUg1ST2i5Mor4eNPKRIlKcaU WUYelKPFE/m+GgLvZCpIxkqDC4CpeEvYdlDLduMgYq/CIVp8O0Noloi8n+SP832xyE8U Dga/KIdqF9wiiuULpCXbM0drVhLbsD0qPvOxE7yB1tzroDYE67MqJIDPwxeCGNwxq+4T /lYcZQGM+PbNsTCn+s3lhrSv76UwE028FJd7eMF7qXhl3k0Q4XfEELool3W5CA72hpXS kNFg== X-Forwarded-Encrypted: i=1; AJvYcCUEMM2clvnKkE7qnk/WXYxnHxdeHnuUou4cLvBymD3NskIoGX3RQTWDFXtovipklao3rHc/HNSDNnMk@vger.kernel.org X-Gm-Message-State: AOJu0YzZzdCVwBuaXhKaAwbybfFikr8IbcA/59hwlAQ43HaIPRhhp/D9 v1avACwp7La9Tuu7792v8N6Xd8vBMNHkEb5lHcXsly32EUrXuQxyDKz1hEIJoGV1qHvruJnzL1x CcV5Qv3GUhv5iGhb/BASZzEI0VcH4lvjIRZJgQarVpytNZuUhNRLFOK8KZ9TAoHEYavyV4b1FTA == X-Gm-Gg: ATEYQzzxNWIUDZOn1GKLttQIoKpRpGjxf8OQvwdUVPGku3x4YBnD8kX4oAQmktkc5vc thKK8WLpeBkJNzAM/tT1sqcGHpn2zFNDQAa6KA0tB8JpUzZSCstU593BrYivT+Jxa4KixQn+2wm F0ciffgW8YGT2Yw4YXJ/+s4/jgnjZalLy3zv+pSR6c7/LVLdxZ2nUWlknZh7cmjHDEJJHMR7KaT anOjlsQyReZdUKOAsVYKjcH3cNVjxxNFYvUG+8RZV1qckZoRGoU5e2hzrOVhb/K7dMfKkqZT0QU mtw5U9wjMuiQ1xG3hiCD93Hn8JZuhDKLTtNQRqHWk15Nhiufq3Fjj0iCxL7aQrgIpaTdw99ywRM eiixmFh8HlmYrw/Ud98sy+Aw8Z0S69yZji8CfCii8D/IaRjkN25kjf17c X-Received: by 2002:a05:620a:3713:b0:8ca:1240:4991 with SMTP id af79cd13be357-8cd6d4f9469mr1830784685a.45.1773148924677; Tue, 10 Mar 2026 06:22:04 -0700 (PDT) X-Received: by 2002:a05:620a:3713:b0:8ca:1240:4991 with SMTP id af79cd13be357-8cd6d4f9469mr1830766185a.45.1773148922638; Tue, 10 Mar 2026 06:22:02 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cd8576db0esm474754485a.47.2026.03.10.06.21.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 06:22:01 -0700 (PDT) Date: Tue, 10 Mar 2026 09:21:58 -0400 From: Brian Masney To: Philipp Hahn Cc: amd-gfx@lists.freedesktop.org, apparmor@lists.ubuntu.com, bpf@vger.kernel.org, ceph-devel@vger.kernel.org, cocci@inria.fr, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, gfs2@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-omap@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-sh@vger.kernel.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, samba-technical@lists.samba.org, sched-ext@lists.linux.dev, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, v9fs@lists.linux.dev, Michael Turquette , Stephen Boyd , Daniel Lezcano , Thomas Gleixner Subject: Re: [PATCH 56/61] clk: Prefer IS_ERR_OR_NULL over manual NULL check Message-ID: References: <20260310-b4-is_err_or_null-v1-0-bd63b656022d@avm.de> <20260310-b4-is_err_or_null-v1-56-bd63b656022d@avm.de> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-b4-is_err_or_null-v1-56-bd63b656022d@avm.de> User-Agent: Mutt/2.2.14 (2025-02-20) On Tue, Mar 10, 2026 at 12:49:22PM +0100, Philipp Hahn wrote: > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Semantich change: Previously the code only printed the warning on error, Semantic ... > but not when the pointer was NULL. Now the warning is printed in both > cases! > > Change found with coccinelle. > > To: Michael Turquette > To: Stephen Boyd > To: Daniel Lezcano > To: Thomas Gleixner > Cc: linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Philipp Hahn With the minor typo addressed: Reviewed-by: Brian Masney