From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0564C5517A for ; Tue, 10 Nov 2020 16:26:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8576720797 for ; Tue, 10 Nov 2020 16:26:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fcQ0HRA9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729819AbgKJQ06 (ORCPT ); Tue, 10 Nov 2020 11:26:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:55672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbgKJQ06 (ORCPT ); Tue, 10 Nov 2020 11:26:58 -0500 Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA85520780; Tue, 10 Nov 2020 16:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605025617; bh=QVkj0WqF0caY1yTdKByO8jOjZpcCRqTc0wTuVsnF+D0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=fcQ0HRA9imwnwDuvTT1275/cezT0hroUsYJhiM4hpY9kaejMfmeNGDxffLDm+45SF ez/fRrj8nzCV2O12e9HTNR0HmIKr2dhqL3YGiIEMd7Dq2ELXJVTZH3hHgZyBXSpGAY bye4T4sYgikczHJi1rvcrRs3Sja6OAIw73nLJ+ls= Message-ID: Subject: Re: [PATCH v3 2/2] ceph: add ceph.{clusterid/clientid} vxattrs suppport From: Jeff Layton To: Ilya Dryomov , Xiubo Li Cc: "Yan, Zheng" , Patrick Donnelly , Ceph Development Date: Tue, 10 Nov 2020 11:26:55 -0500 In-Reply-To: References: <20201110141703.414211-1-xiubli@redhat.com> <20201110141703.414211-3-xiubli@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.1 (3.38.1-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, 2020-11-10 at 16:59 +0100, Ilya Dryomov wrote: > On Tue, Nov 10, 2020 at 3:17 PM wrote: > > > > From: Xiubo Li > > > > These two vxattrs will only exist in local client side, with which > > we can easily know which mountpoint the file belongs to and also > > they can help locate the debugfs path quickly. > > > > URL: https://tracker.ceph.com/issues/48057 > > Signed-off-by: Xiubo Li > > --- > >  fs/ceph/xattr.c | 42 ++++++++++++++++++++++++++++++++++++++++++ > >  1 file changed, 42 insertions(+) > > > > diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c > > index 0fd05d3d4399..4a41db46e191 100644 > > --- a/fs/ceph/xattr.c > > +++ b/fs/ceph/xattr.c > > @@ -304,6 +304,23 @@ static ssize_t ceph_vxattrcb_snap_btime(struct ceph_inode_info *ci, char *val, > >                                 ci->i_snap_btime.tv_nsec); > >  } > > > > +static ssize_t ceph_vxattrcb_clusterid(struct ceph_inode_info *ci, > > + char *val, size_t size) > > +{ > > + struct ceph_fs_client *fsc = ceph_sb_to_client(ci->vfs_inode.i_sb); > > + > > + return ceph_fmt_xattr(val, size, "%pU", &fsc->client->fsid); > > +} > > + > > +static ssize_t ceph_vxattrcb_clientid(struct ceph_inode_info *ci, > > + char *val, size_t size) > > +{ > > + struct ceph_fs_client *fsc = ceph_sb_to_client(ci->vfs_inode.i_sb); > > + > > + return ceph_fmt_xattr(val, size, "client%lld", > > + ceph_client_gid(fsc->client)); > > +} > > + > >  #define CEPH_XATTR_NAME(_type, _name) XATTR_CEPH_PREFIX #_type "." #_name > >  #define CEPH_XATTR_NAME2(_type, _name, _name2) \ > >         XATTR_CEPH_PREFIX #_type "." #_name "." #_name2 > > @@ -407,6 +424,24 @@ static struct ceph_vxattr ceph_file_vxattrs[] = { > >         { .name = NULL, 0 } /* Required table terminator */ > >  }; > > > > +static struct ceph_vxattr ceph_vxattrs[] = { > > + { > > + .name = "ceph.clusterid", > > I think this should be "ceph.cluster_fsid" > > > + .name_size = sizeof("ceph.clusterid"), > > + .getxattr_cb = ceph_vxattrcb_clusterid, > > + .exists_cb = NULL, > > + .flags = VXATTR_FLAG_READONLY, > > + }, > > + { > > + .name = "ceph.clientid", > > and this should be "ceph.client_id". It's easier to read, consistent > with "ceph fsid" command and with existing rbd attributes: > >   static DEVICE_ATTR(client_id, 0444, rbd_client_id_show, NULL); >   static DEVICE_ATTR(cluster_fsid, 0444, rbd_cluster_fsid_show, NULL); > That sounds like a good idea. Xiubo, would you mind sending a v4? Thanks, -- Jeff Layton