Re: [PATCH v2 0/2] ceph: send io size metrics to mds daemon

[Jeff Layton <jlayton@kernel.org>]

On Tue, 2021-05-18 at 09:00 +0800, Xiubo Li wrote:
> On 5/17/21 11:46 PM, Jeff Layton wrote:
> > On Fri, 2021-05-14 at 17:14 +0800, Xiubo Li wrote:
> > > On 5/14/21 4:57 PM, Ilya Dryomov wrote:
> > > > On Fri, May 14, 2021 at 2:47 AM Xiubo Li <xiubli@redhat.com> wrote:
> > > > > On 5/13/21 7:30 PM, Jeff Layton wrote:
> > > > > > On Thu, 2021-05-13 at 09:40 +0800, xiubli@redhat.com wrote:
> > > > > > > From: Xiubo Li <xiubli@redhat.com>
> > > > > > > 
> > > > > > > V2:
> > > > > > > - change the patch order
> > > > > > > - replace the fixed 10 with sizeof(struct ceph_metric_header)
> > > > > > > 
> > > > > > > Xiubo Li (2):
> > > > > > >      ceph: simplify the metrics struct
> > > > > > >      ceph: send the read/write io size metrics to mds
> > > > > > > 
> > > > > > >     fs/ceph/metric.c | 90 ++++++++++++++++++++++++++++++------------------
> > > > > > >     fs/ceph/metric.h | 79 +++++++++++++++++-------------------------
> > > > > > >     2 files changed, 89 insertions(+), 80 deletions(-)
> > > > > > > 
> > > > > > Thanks Xiubo,
> > > > > > 
> > > > > > These look good. I'll do some testing with them and plan to merge these
> > > > > > into the testing branch later today.
> > > > > Sure, take your time.
> > > > FYI I squashed "ceph: send the read/write io size metrics to mds" into
> > > > "ceph: add IO size metrics support".
> > I've dropped this combined patch for now, as it was triggering an MDS
> > assertion that was hampering testing [1]. I'll plan to add it back once
> > that problem is resolved in the MDS.
> > 
> > [1]: https://github.com/ceph/ceph/pull/41357
> > 
> > Cheers,
> 
> Ack. Thanks.
> 
> 

Patrick mentioned that the problem with the MDS has now been resolved,
so I've gone ahead and merged this patch back into testing branch. Let
me know if you see any more issues.

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>