From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96CBAC388F9 for ; Sat, 31 Oct 2020 14:58:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 634A4206E9 for ; Sat, 31 Oct 2020 14:58:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="uVP5oeGo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgJaO65 (ORCPT ); Sat, 31 Oct 2020 10:58:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727672AbgJaO64 (ORCPT ); Sat, 31 Oct 2020 10:58:56 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49DE0C0617A6 for ; Sat, 31 Oct 2020 07:58:55 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id o129so7543712pfb.1 for ; Sat, 31 Oct 2020 07:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0zr0b/y5rkNm6oxrz4+W0bMdaVZDG5gT02DeVbHw98o=; b=uVP5oeGo2YZHfMjuITKgMCFLRKszKlLHhu3NYhX0ToMOD9q3WR0wGFUFkWhaYhtsqt BAXEhyU8dThRZMaOj2G/t8Pe1U4C83abPqUdJdvBRsprfX4o3o0dNPUzXz+OTNzS4Hsp CUEhW0B8wY/RY+Th4RHI/09LirVvsxeVY9fEajaAgZIl+25Fb/2PCrfAyx476Qzl+TQm CUUJidojEoMdNDmnDrCZARO6HcTvO8Caib55eG/L0aYjM/BPpAQIazpSmTMFoYpfInIj RX3g3AP8AH3sA5rTGyq6Ghbu2bsLlNEE7x6UAT9gEFpa4OPcO4FgxEZBWLDJaVVE+aiH YKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0zr0b/y5rkNm6oxrz4+W0bMdaVZDG5gT02DeVbHw98o=; b=qPR8kmg/e+gHOTQVZcJCDr12G4ha8bnGVDXN3A/QKjTc1nkQfL4FAXNt91+qrT40S9 FJeqk2cPNmrxmVCP84aX6ZlbB0t1sGk3sc3OpCu++4yg65S+/O30wfQ31kRT14LdrT1P bgbMUNqKNqWFXbYolBjOSGHX2a9CAs+e2aVui2SaPtVNi8Tscf1wp5P6IZpJMuDlGsl+ 3aBG7M5EAnQIan6LIg5fjgOcpZNBCXfhfG5k5ijAFUWMenD+vJ23q0cZs+JwuTeHgaOO inRIiguDLZgrnVE2zYq45sQsPhEmBOIp5PHvyLEkYC0aTUcJFeSmPAMFKtjEbVjPm8RR yNmQ== X-Gm-Message-State: AOAM531m8+taLwUQJYXmpnNQMP/HH2B+5zFg+LH8wX7SOg5Neu6zPRhH oiYCR+8ZpE+O+i40HL+AV6MghQ== X-Google-Smtp-Source: ABdhPJxu4Rg5DJXBVruN6ahpydQKdUXsdC1eafH3KHv2+x9uXffRNUui5KAFMqg9AwAVU2K7WSB8Ww== X-Received: by 2002:a63:1b41:: with SMTP id b1mr6826953pgm.274.1604156334647; Sat, 31 Oct 2020 07:58:54 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id q84sm9374774pfq.144.2020.10.31.07.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Oct 2020 07:58:53 -0700 (PDT) Subject: Re: [PATCH 02/11] mtip32xx: return -ENOTTY for all unhanled ioctls To: Christoph Hellwig Cc: Ilya Dryomov , Song Liu , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Stefan Haberland , Jan Hoeppner , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mtd@lists.infradead.org, linux-s390@vger.kernel.org References: <20201031085810.450489-1-hch@lst.de> <20201031085810.450489-3-hch@lst.de> From: Jens Axboe Message-ID: Date: Sat, 31 Oct 2020 08:58:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201031085810.450489-3-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 10/31/20 2:58 AM, Christoph Hellwig wrote: > -ENOTTY is the convention for "driver does not support this ioctl". > Use it properly in mtip32xx instead of the bogys -EINVAL. While that's certainly true, there is a risk in making a change like this years after the fact. Not that I expect there are any mtip32xx users left at this point, but... -- Jens Axboe