From: Alexandre Oliva <oliva@gnu.org>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] enable mds rejoin with active inodes' old parent xattrs
Date: Fri, 23 Aug 2013 08:00:11 -0300 [thread overview]
Message-ID: <orppt4k6ys.fsf@livre.home> (raw)
In-Reply-To: <CAAM7YAk+1pZsn8=f-Z+wxzm+4-zkKQCN52gVTWot6e_OmHDSTQ@mail.gmail.com> (Zheng Yan's message of "Thu, 22 Aug 2013 16:27:24 +0800")
On Aug 22, 2013, "Yan, Zheng" <ukernel@gmail.com> wrote:
> This is not bug. Only the tail entry of the path encoded in the parent xattrs
> need to be updated. (the entry for inode's parent directory)
Why store the others, if they're not usable, then? IMHO it just
introduces a risk of their being accidentally misused.
> Cuttlefish also has this issue, it just does not print the error message
> to console.
Speaking of Cuttlefish, I don't think my statement that I'd run into
this issue in Cuttlefish was correct: I don't see similar code to the
one I patched there, and indeed, (accidentally) starting a Cuttlefish
mds on an otherwise Dumpling cluster enabled recovery to complete where
Dumpling's mds wouldn't. So, no backporting for this patch of mine, I
think.
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer
next prev parent reply other threads:[~2013-08-23 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 6:40 [PATCH] enable mds rejoin with active inodes' old parent xattrs Alexandre Oliva
2013-08-22 8:27 ` Yan, Zheng
2013-08-22 15:16 ` Sage Weil
2013-08-23 11:00 ` Alexandre Oliva [this message]
2013-08-23 20:11 ` Gregory Farnum
2013-08-24 10:38 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=orppt4k6ys.fsf@livre.home \
--to=oliva@gnu.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox