From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD03346765 for ; Thu, 15 Jan 2026 09:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469558; cv=none; b=OnfIWutsl1Q5CfgeKNzkjaHhG0+vcov1xxxEWZMue3wJzN+TjMLv++Zh/i6GWx4XW1JGeMsYiHl/UtPlXP6ISj9bFQOgGfJgWSl4Tat3hRlJJIEkijFHU8sdJtvTiJ6bY6WKl6cVmSM1fCDRPyXuurLs3mRIMGRNV32XJmCW8l8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768469558; c=relaxed/simple; bh=6mb6VFI0MLzl8UW6nAgTjfQwiWBLbhWxDvrM6W4yKdo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EV/UwdVUtrlmBtg7n4fY+Lky3uz9/0PjP5sft4HRchNLeurNE9FRnTJkmPeVtY53w7BAfOnxzS79KeL1ycgV5YG6nnDKqyAzDgAlwOfZDNBKexs/zhXvzIfAv7NUDdJK9IhXSPB4fXWPop2uG1IUPV2oyGJdTcBPXSK6ecSCO/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=GcsVSwgK; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="GcsVSwgK" Message-ID: <01395cef-a258-412d-b9d2-0f61283d4578@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768469543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+iUgOjFTTbfQE7v33IT3NHTL6I0hG/q7V1catUOwvKs=; b=GcsVSwgKXy4alPkRnDgg2qI+A++Z9txlnnBJi5pNZvhr78GeYOahv8qeXEbWbZJduOSwno an4CS+iaHDlSLa+i0No+4LXxYeBiUG9Mft5PAKZf+xMcRu7x58EWOcGJUxmHDCgojiuhaa NSpEeJKKKZ1z7HE4mnkjjvrLz/ebCRY= Date: Thu, 15 Jan 2026 17:31:51 +0800 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v3 23/30] mm: do not open-code lruvec lock To: Baoquan He Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng References: <33fef62fd821f669fcdc999e54c4035a4e91b47d.1768389889.git.zhengqi.arch@bytedance.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/15/26 5:26 PM, Baoquan He wrote: > On 01/14/26 at 07:32pm, Qi Zheng wrote: >> From: Qi Zheng >> >> Now we have lruvec_unlock(), lruvec_unlock_irq() and >> lruvec_unlock_irqrestore(), but not the paired lruvec_lock(), > ~~ typo, 'no'? >> lruvec_lock_irq() and lruvec_lock_irqsave(). >> >> There is currently no use case for lruvec_lock_irqsave(), so only >> introduce lruvec_lock() and lruvec_lock_irq(), and change all open-code > > I didn't see lruvec_lock() is introduced in this patch, do I miss > anthing? I forgot to update commit message when I deleted lruvec_lock(), will modify it in the next version. Thanks! > >> places to use these helper function. This looks cleaner and prepares for >> reparenting LRU pages, preventing user from missing RCU lock calls due to >> open-code lruvec lock. >> >> Signed-off-by: Qi Zheng >> --- >> include/linux/memcontrol.h | 5 +++++ >> mm/vmscan.c | 38 +++++++++++++++++++------------------- >> 2 files changed, 24 insertions(+), 19 deletions(-) >> >> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h >> index f1556759d0d3f..4b6f20dc694ba 100644 >> --- a/include/linux/memcontrol.h >> +++ b/include/linux/memcontrol.h >> @@ -1499,6 +1499,11 @@ static inline struct lruvec *parent_lruvec(struct lruvec *lruvec) >> return mem_cgroup_lruvec(memcg, lruvec_pgdat(lruvec)); >> } >> >> +static inline void lruvec_lock_irq(struct lruvec *lruvec) >> +{ >> + spin_lock_irq(&lruvec->lru_lock); >> +} >> + >> static inline void lruvec_unlock(struct lruvec *lruvec) >> { >> spin_unlock(&lruvec->lru_lock); >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index f206d4dac9e77..c48ff6e05e004 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -2020,7 +2020,7 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, >> >> lru_add_drain(); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> >> nr_taken = isolate_lru_folios(nr_to_scan, lruvec, &folio_list, >> &nr_scanned, sc, lru); >> @@ -2032,7 +2032,7 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, >> count_memcg_events(lruvec_memcg(lruvec), item, nr_scanned); >> __count_vm_events(PGSCAN_ANON + file, nr_scanned); >> >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> >> if (nr_taken == 0) >> return 0; >> @@ -2051,7 +2051,7 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, >> count_memcg_events(lruvec_memcg(lruvec), item, nr_reclaimed); >> count_vm_events(PGSTEAL_ANON + file, nr_reclaimed); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> lru_note_cost_unlock_irq(lruvec, file, stat.nr_pageout, >> nr_scanned - nr_reclaimed); >> >> @@ -2130,7 +2130,7 @@ static void shrink_active_list(unsigned long nr_to_scan, >> >> lru_add_drain(); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> >> nr_taken = isolate_lru_folios(nr_to_scan, lruvec, &l_hold, >> &nr_scanned, sc, lru); >> @@ -2141,7 +2141,7 @@ static void shrink_active_list(unsigned long nr_to_scan, >> __count_vm_events(PGREFILL, nr_scanned); >> count_memcg_events(lruvec_memcg(lruvec), PGREFILL, nr_scanned); >> >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> >> while (!list_empty(&l_hold)) { >> struct folio *folio; >> @@ -2197,7 +2197,7 @@ static void shrink_active_list(unsigned long nr_to_scan, >> count_memcg_events(lruvec_memcg(lruvec), PGDEACTIVATE, nr_deactivate); >> mod_node_page_state(pgdat, NR_ISOLATED_ANON + file, -nr_taken); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> lru_note_cost_unlock_irq(lruvec, file, 0, nr_rotated); >> trace_mm_vmscan_lru_shrink_active(pgdat->node_id, nr_taken, nr_activate, >> nr_deactivate, nr_rotated, sc->priority, file); >> @@ -3832,9 +3832,9 @@ static void walk_mm(struct mm_struct *mm, struct lru_gen_mm_walk *walk) >> } >> >> if (walk->batched) { >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> reset_batch_size(walk); >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> } >> >> cond_resched(); >> @@ -3993,7 +3993,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsigned long seq, int swappiness >> if (seq < READ_ONCE(lrugen->max_seq)) >> return false; >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> >> VM_WARN_ON_ONCE(!seq_is_valid(lruvec)); >> >> @@ -4008,7 +4008,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsigned long seq, int swappiness >> if (inc_min_seq(lruvec, type, swappiness)) >> continue; >> >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> cond_resched(); >> goto restart; >> } >> @@ -4043,7 +4043,7 @@ static bool inc_max_seq(struct lruvec *lruvec, unsigned long seq, int swappiness >> /* make sure preceding modifications appear */ >> smp_store_release(&lrugen->max_seq, lrugen->max_seq + 1); >> unlock: >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> >> return success; >> } >> @@ -4739,7 +4739,7 @@ static int evict_folios(unsigned long nr_to_scan, struct lruvec *lruvec, >> struct mem_cgroup *memcg = lruvec_memcg(lruvec); >> struct pglist_data *pgdat = lruvec_pgdat(lruvec); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> >> scanned = isolate_folios(nr_to_scan, lruvec, sc, swappiness, &type, &list); >> >> @@ -4748,7 +4748,7 @@ static int evict_folios(unsigned long nr_to_scan, struct lruvec *lruvec, >> if (evictable_min_seq(lrugen->min_seq, swappiness) + MIN_NR_GENS > lrugen->max_seq) >> scanned = 0; >> >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> >> if (list_empty(&list)) >> return scanned; >> @@ -4786,9 +4786,9 @@ static int evict_folios(unsigned long nr_to_scan, struct lruvec *lruvec, >> walk = current->reclaim_state->mm_walk; >> if (walk && walk->batched) { >> walk->lruvec = lruvec; >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> reset_batch_size(walk); >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> } >> >> mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(sc), >> @@ -5226,7 +5226,7 @@ static void lru_gen_change_state(bool enabled) >> for_each_node(nid) { >> struct lruvec *lruvec = get_lruvec(memcg, nid); >> >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> >> VM_WARN_ON_ONCE(!seq_is_valid(lruvec)); >> VM_WARN_ON_ONCE(!state_is_valid(lruvec)); >> @@ -5234,12 +5234,12 @@ static void lru_gen_change_state(bool enabled) >> lruvec->lrugen.enabled = enabled; >> >> while (!(enabled ? fill_evictable(lruvec) : drain_evictable(lruvec))) { >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> cond_resched(); >> - spin_lock_irq(&lruvec->lru_lock); >> + lruvec_lock_irq(lruvec); >> } >> >> - spin_unlock_irq(&lruvec->lru_lock); >> + lruvec_unlock_irq(lruvec); >> } >> >> cond_resched(); >> -- >> 2.20.1 >> >> >