From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Christoph Hellwig <hch@infradead.org>
Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: update comment for blkcg_init_queue
Date: Wed, 15 Jun 2022 14:21:09 +0800 [thread overview]
Message-ID: <01f643e5-fb5e-66fd-7bf9-937738bf306d@linux.dev> (raw)
In-Reply-To: <Yql5wrthJvZDwWjq@infradead.org>
On 6/15/22 2:18 PM, Christoph Hellwig wrote:
> On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote:
>> It was called from __alloc_disk_node since commit 1059699f87eb ("block:
>> move blkcg initialization/destroy into disk allocation/release handler).
>> Let's change the comment accordingly.
> Well, the right things is to simply drop this comment. I do have
> a large series toucing it and removing it, so maybe we can wait
> until that?
Sure, I am fine with it.
Thanks,
Guoqing
prev parent reply other threads:[~2022-06-15 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 10:05 [PATCH] block: update comment for blkcg_init_queue Guoqing Jiang
[not found] ` <20220614100556.20899-1-guoqing.jiang-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
2022-06-15 6:18 ` Christoph Hellwig
2022-06-15 6:21 ` Guoqing Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f643e5-fb5e-66fd-7bf9-937738bf306d@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).