Re: [PATCH 11/11] cgroup: separate rstat list pointers from base stats

Shakeel Butt
2025-02-22T00:29:08Z

On Mon, Feb 17, 2025 at 07:14:48PM -0800, JP Kobryn wrote:
> A majority of the cgroup_rstat_cpu struct size is made up of the base stat
> entities. Since only the "self" subsystem state makes use of these, move
> them into a struct of their own. This allows for a new compact
> cgroup_rstat_cpu struct that the formal subsystems can make use of.
> Where applicable, decide on whether to allocate the compact or the full
> struct including the base stats.
>
> Signed-off-by: JP Kobryn <inwardvessel@gmail.com>

This looks good. Now there are two major asks and then minor comments on
some individual patches.

Two main asks are:
1. Experiment requested by Tejun.
2. BPF rstat using the base subsystem as requested by Yosry.

I would say send the v2 addressing these requests.