From: "Yosry Ahmed" <yosry.ahmed@linux.dev>
To: "Shakeel Butt" <shakeel.butt@linux.dev>, "Tejun Heo" <tj@kernel.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Meta kernel team" <kernel-team@meta.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Breno Leitao" <leitao@debian.org>,
"Venkat Rao Bagalkote" <venkat88@linux.ibm.com>
Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock
Date: Tue, 01 Apr 2025 21:37:53 +0000 [thread overview]
Message-ID: <07d65709cbc9e4e0fbf25da7d7e70e19aec7409d@linux.dev> (raw)
In-Reply-To: <20250401170912.2161953-1-shakeel.butt@linux.dev>
April 1, 2025 at 7:09 PM, "Shakeel Butt" <shakeel.butt@linux.dev> wrote:
>
> The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and
> locking") during cleanup accidentally changed the code to call
> cgroup_rstat_updated_list() without cgroup_rstat_lock which is required.
> Fix it.
>
> Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Reported-by: Breno Leitao <leitao@debian.org>
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca4@linux.ibm.com/
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
Thanks for fixing this.
Reviewed-by: Yosry Ahmed <yosry.ahmed@linux.dev>
next prev parent reply other threads:[~2025-04-01 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 17:09 [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock Shakeel Butt
2025-04-01 17:33 ` Tejun Heo
2025-04-01 21:37 ` Yosry Ahmed [this message]
2025-04-02 11:40 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07d65709cbc9e4e0fbf25da7d7e70e19aec7409d@linux.dev \
--to=yosry.ahmed@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).