From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00ED92036FA for ; Tue, 1 Apr 2025 21:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743543489; cv=none; b=hzT0JH04UAzJukOVrXwXwkhChLiTgJ0Gt2sSodyZn1WPSue5QkKu8pTnNAVuRxr+/tfF35riIma5SIidq4OUt/C346kF1vBnVx1DT6q4C+b5yno+9joeJoqr6UxsLWcMkLbJdBiD4VC5CBs/bU4UINADOzxEfZzqmt3xtDBcvkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743543489; c=relaxed/simple; bh=Td1LRDkkGYyldpNI6UbONyAt4GsxuIED4xPo3I8nrrk=; h=MIME-Version:Date:Content-Type:From:Message-ID:Subject:To:Cc: In-Reply-To:References; b=d55mo3HhSTF8jo7zZeLK1SaPViuySQyoaW7I4QOYfqQPe8OvT+9WO3yXUvlfKA1YjtNJNapzhvs5fQs88riyEoSUy9gfC32b09SQ3nZg3ZG89b+jajxiAxSmCAUFsBpYhhV2y2jrDyi5osDEDl1JlcYSNqQEzS1zCb86npQ2te8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Jy6SaD/C; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Jy6SaD/C" Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1743543475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Td1LRDkkGYyldpNI6UbONyAt4GsxuIED4xPo3I8nrrk=; b=Jy6SaD/CMeGr3h+1j0RP7cdzlPLbYg1V84A4lkTh/GDTbsZBDGOfHDMAJuoFgpHe7wa12c sse06pJw3QHlcMVA8Oou5jG5XU/+q9KZmHzqdemdCFsX3xpww2Th55S93kYHFiAD9OsKj0 yIlFYyswy0NAlnJCVqc+b36HjoJI8gE= Date: Tue, 01 Apr 2025 21:37:53 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yosry Ahmed" Message-ID: <07d65709cbc9e4e0fbf25da7d7e70e19aec7409d@linux.dev> TLS-Required: No Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock To: "Shakeel Butt" , "Tejun Heo" Cc: "Johannes Weiner" , "=?utf-8?B?TWljaGFsIEtvdXRuw70=?=" , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, "Meta kernel team" , "Jakub Kicinski" , "Breno Leitao" , "Venkat Rao Bagalkote" In-Reply-To: <20250401170912.2161953-1-shakeel.butt@linux.dev> References: <20250401170912.2161953-1-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT April 1, 2025 at 7:09 PM, "Shakeel Butt" wrote: >=20 >=20The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions a= nd > locking") during cleanup accidentally changed the code to call > cgroup_rstat_updated_list() without cgroup_rstat_lock which is required= .=20 >=20Fix it. >=20 >=20Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and l= ocking") > Reported-by: Jakub Kicinski > Reported-by: Breno Leitao > Reported-by: Venkat Rao Bagalkote > Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca= 4@linux.ibm.com/ > Signed-off-by: Shakeel Butt Thanks for fixing this. Reviewed-by: Yosry Ahmed