cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
To: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	KAMEZAWA Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	Balbir Singh
	<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"Kirill A. Shutemov"
	<kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
Subject: [PATCH 1/6] memcg: fix unused variable warning
Date: Sat, 24 Dec 2011 05:00:14 +0200	[thread overview]
Message-ID: <1324695619-5537-1-git-send-email-kirill@shutemov.name> (raw)

From: "Kirill A. Shutemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>

mm/memcontrol.c: In function ‘memcg_check_events’:
mm/memcontrol.c:784:22: warning: unused variable ‘do_numainfo’ [-Wunused-variable]

Signed-off-by: Kirill A. Shutemov <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
---
 mm/memcontrol.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d643bd6..a5e92bd 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -781,14 +781,15 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page)
 	/* threshold event is triggered in finer grain than soft limit */
 	if (unlikely(mem_cgroup_event_ratelimit(memcg,
 						MEM_CGROUP_TARGET_THRESH))) {
-		bool do_softlimit, do_numainfo;
+		bool do_softlimit;
 
-		do_softlimit = mem_cgroup_event_ratelimit(memcg,
-						MEM_CGROUP_TARGET_SOFTLIMIT);
 #if MAX_NUMNODES > 1
+		bool do_numainfo;
 		do_numainfo = mem_cgroup_event_ratelimit(memcg,
 						MEM_CGROUP_TARGET_NUMAINFO);
 #endif
+		do_softlimit = mem_cgroup_event_ratelimit(memcg,
+						MEM_CGROUP_TARGET_SOFTLIMIT);
 		preempt_enable();
 
 		mem_cgroup_threshold(memcg);
-- 
1.7.7.3

             reply	other threads:[~2011-12-24  3:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-24  3:00 Kirill A. Shutemov [this message]
2011-12-24  3:00 ` [PATCH 2/6] memcg: mark more functions/variables as static Kirill A. Shutemov
     [not found]   ` <1324695619-5537-2-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:28     ` KAMEZAWA Hiroyuki
2011-12-27 14:05     ` Michal Hocko
2011-12-24  3:00 ` [PATCH 3/6] memcg: remove unused variable Kirill A. Shutemov
2011-12-26  6:29   ` KAMEZAWA Hiroyuki
     [not found]   ` <1324695619-5537-3-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-27 14:08     ` Michal Hocko
2011-12-24  3:00 ` [PATCH 4/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
     [not found]   ` <1324695619-5537-4-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:30     ` KAMEZAWA Hiroyuki
2011-12-27 14:11     ` Michal Hocko
2011-12-24  3:00 ` [PATCH 5/6] memcg: fix broken boolen expression Kirill A. Shutemov
     [not found]   ` <1324695619-5537-5-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:31     ` KAMEZAWA Hiroyuki
     [not found]       ` <20111226153138.0376bd66.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:57         ` Kirill A. Shutemov
     [not found]           ` <20111226065724.GA13459-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2012-01-03 20:54             ` Greg KH
2011-12-27 14:17     ` Michal Hocko
2012-04-04 21:34     ` Andrew Morton
     [not found]       ` <20120404143403.fd05a284.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-04-05 10:17         ` Kirill A. Shutemov
2011-12-24  3:00 ` [PATCH 6/6] memcg: drop redundant brackets Kirill A. Shutemov
2011-12-26  6:40   ` KAMEZAWA Hiroyuki
2011-12-27 14:28   ` Michal Hocko
2011-12-26  6:25 ` [PATCH 1/6] memcg: fix unused variable warning KAMEZAWA Hiroyuki
     [not found]   ` <20111226152531.e0335ec4.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:36     ` Kirill A. Shutemov
     [not found]       ` <20111226063652.GA13273-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:42         ` KAMEZAWA Hiroyuki
     [not found]           ` <20111226154252.d3621532.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-12-26  6:47             ` Kirill A. Shutemov
     [not found]               ` <20111226064734.GA13355-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-26  6:50                 ` KAMEZAWA Hiroyuki
2011-12-27 13:57 ` [PATCH] Makefiles: Disable unused-variable warning (was: Re: [PATCH 1/6] memcg: fix unused variable warning) Michal Hocko
2011-12-27 18:26   ` Kirill A. Shutemov
     [not found]     ` <20111227182613.GA21840-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-29 10:42       ` Michal Hocko
2011-12-29 11:08         ` Kirill A. Shutemov
     [not found]           ` <20111229110850.GA5680-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2011-12-29 11:16             ` Michal Hocko
     [not found]   ` <20111227135752.GK5344-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-01-08 15:01     ` [PATCH] Makefiles: Disable unused-variable warning Michal Marek
2012-01-10  8:52       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324695619-5537-1-git-send-email-kirill@shutemov.name \
    --to=kirill-okw7cidhh8elwutg50ltga@public.gmane.org \
    --cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).