From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org
Cc: vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCHSET] block: per-queue policy activation
Date: Thu, 12 Apr 2012 16:29:32 -0700 [thread overview]
Message-ID: <1334273380-30233-1-git-send-email-tj@kernel.org> (raw)
Hello,
It seems that we're *finally* nearing the end of the long blkcg API
cleanup. With all the previous updates, blkcg code is now clean &
modular enough to implement per-queue policy activation.
Upto now, blkcg assumed that all policies are active on all queues
which simply isn't true - cfq policy is only applicable to queues
which are using cfq as the elevator. Also, for transition purposes,
the current implementation clears all !root blkgs blkgs across
elevator switch and policy [de]registration in racy manner.
This patchset implements per-queue policy activation. Static policy
ID is replaced with dynamic registration and each policy should be
activated and deactivated explicitly on each queue. On activation,
the matching policy data are created on all existing blkgs. On
deactivation, the matching policy data are removed from all existing
blkgs. blkg printing skips blkg-policy combination which is disabled
and trying to configure a policy on a blkg which doesn't have the
policy enabled would return -EINVAL instead of creating an unused
dummy configuration.
0001-blkcg-kill-blkio_list-and-replace-blkio_list_lock-wi.patch
0002-blkcg-use-pol-instead-of-plid-in-update_root_blkg_pd.patch
0003-blkcg-remove-static-policy-ID-enums.patch
0004-blkcg-make-blkg_conf_prep-take-pol-and-return-with-q.patch
0005-blkcg-make-sure-blkg_lookup-returns-NULL-if-q-is-byp.patch
0006-blkcg-add-request_queue-root_blkg.patch
0007-blkcg-implement-per-queue-policy-activation.patch
0008-blkcg-drop-stuff-unused-after-per-queue-policy-activ.patch
0001-0003 removes static policy IDs.
0004-0006 are prep patches.
0007 implements per-queue policy activation.
0008 drops unnecessary stuff.
This patchset is on top of the current block/for-3.5/core 5bc4afb1ec
"blkcg: drop BLKCG_STAT_{PRIV|POL|OFF} macros" and also available in
the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blkcg-pols
diffstat follows.
block/blk-cgroup.c | 424 ++++++++++++++++++++++++++++++-------------------
block/blk-cgroup.h | 43 ++--
block/blk-core.c | 4
block/blk-throttle.c | 78 +++------
block/cfq-iosched.c | 71 ++++----
block/elevator.c | 2
include/linux/blkdev.h | 10 +
7 files changed, 367 insertions(+), 265 deletions(-)
Thanks.
--
tejun
next reply other threads:[~2012-04-12 23:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 23:29 Tejun Heo [this message]
[not found] ` <1334273380-30233-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-12 23:29 ` [PATCH 1/8] blkcg: kill blkio_list and replace blkio_list_lock with a mutex Tejun Heo
[not found] ` <1334273380-30233-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 13:32 ` Vivek Goyal
[not found] ` <20120413133226.GB26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 16:55 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 2/8] blkcg: use @pol instead of @plid in update_root_blkg_pd() and blkcg_print_blkgs() Tejun Heo
2012-04-12 23:29 ` [PATCH 3/8] blkcg: remove static policy ID enums Tejun Heo
2012-04-12 23:29 ` [PATCH 4/8] blkcg: make blkg_conf_prep() take @pol and return with queue lock held Tejun Heo
2012-04-12 23:29 ` [PATCH 5/8] blkcg: make sure blkg_lookup() returns %NULL if @q is bypassing Tejun Heo
[not found] ` <1334273380-30233-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 16:00 ` Vivek Goyal
[not found] ` <20120413160053.GE26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:03 ` Tejun Heo
[not found] ` <20120413170334.GB12233-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:23 ` Vivek Goyal
[not found] ` <20120413172336.GF26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 17:28 ` Tejun Heo
2012-04-16 22:41 ` Paul E. McKenney
2012-04-12 23:29 ` [PATCH 6/8] blkcg: add request_queue->root_blkg Tejun Heo
2012-04-12 23:29 ` [PATCH 7/8] blkcg: implement per-queue policy activation Tejun Heo
[not found] ` <1334273380-30233-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-04-13 15:21 ` Vivek Goyal
[not found] ` <20120413152122.GC26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 15:23 ` Vivek Goyal
2012-04-13 18:12 ` Vivek Goyal
[not found] ` <20120413181257.GG26383-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-04-13 18:17 ` Tejun Heo
2012-04-12 23:29 ` [PATCH 8/8] blkcg: drop stuff unused after per-queue policy activation update Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334273380-30233-1-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).