From: Greg Thelen <gthelen@google.com>
To: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>
Cc: containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Thelen <gthelen@google.com>
Subject: [PATCH 2/2] cgroups: fix cgroup_event_listener error handling
Date: Fri, 4 Jan 2013 13:05:18 -0800 [thread overview]
Message-ID: <1357333518-28899-2-git-send-email-gthelen@google.com> (raw)
In-Reply-To: <1357333518-28899-1-git-send-email-gthelen@google.com>
If the <absolute-path-to-control-file> command line parameter cannot
be opened, then cgroup_event_listener prints an error message and
tries to return an error. However, due to an uninitialized variable
the return value was undefined.
With this patch such failures always return non-zero error.
Compiler warning found this:
$ gcc -Wall -O2 cgroup_event_listener.c
cgroup_event_listener.c: In function ‘main’:
cgroup_event_listener.c:109:2: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized]
Signed-off-by: Greg Thelen <gthelen@google.com>
---
tools/cgroup/cgroup_event_listener.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/cgroup/cgroup_event_listener.c b/tools/cgroup/cgroup_event_listener.c
index 3e082f9..a70f00c 100644
--- a/tools/cgroup/cgroup_event_listener.c
+++ b/tools/cgroup/cgroup_event_listener.c
@@ -35,7 +35,7 @@ int main(int argc, char **argv)
if (cfd == -1) {
fprintf(stderr, "Cannot open %s: %s\n", argv[1],
strerror(errno));
- goto out;
+ return 1;
}
ret = snprintf(event_control_path, PATH_MAX, "%s/cgroup.event_control",
--
1.7.7.3
next prev parent reply other threads:[~2013-01-04 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 21:05 [PATCH 1/2] cgroups: move cgroup_event_listener.c to tools/cgroup Greg Thelen
2013-01-04 21:05 ` Greg Thelen [this message]
2013-01-07 17:44 ` [PATCH 2/2] cgroups: fix cgroup_event_listener error handling Tejun Heo
[not found] ` <20130107174427.GM3926-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-01-07 19:50 ` Greg Thelen
[not found] ` <xr93a9sklqme.fsf-aSPv4SP+Du0KgorLzL7FmE7CuiCeIGUxQQ4Iyu8u01E@public.gmane.org>
2013-01-08 6:28 ` Li Zefan
[not found] ` <50EBBC9C.7060909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-01-08 18:08 ` Tejun Heo
2013-01-07 17:42 ` [PATCH 1/2] cgroups: move cgroup_event_listener.c to tools/cgroup Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357333518-28899-2-git-send-email-gthelen@google.com \
--to=gthelen@google.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).