Re: [PATCH v3 00/32] memcg-aware slab shrinking with lasers and numbers

Glauber Costa
2013-04-09T07:25:09Z

On 04/09/2013 12:51 AM, Andrew Morton wrote:
> On Mon, 8 Apr 2013 18:00:27 +0400 Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> wrote:
>
>> Cc: Dave Shrinnker <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
>
> I keep on receiving emails from people who claim they can fix this.
>

=)

>> This patchset implements targeted shrinking for memcg when kmem limits are
>> present. So far, we've been accounting kernel objects but failing allocations
>> when short of memory. This is because our only option would be to call the
>> global shrinker, depleting objects from all caches and breaking isolation.
>
> This is a fine-looking patchset and it even has some acks and reviews.
> But it's huuuuge and we're at -rc6 and I've been offline for a week and
> have 975 emails in my to-apply folder.
>
> So, err, I think I'll bestow upon everyone some additional time to
> review the code ;) Please resend for -rc1?
>
Sure. This was still a mostly asynchronous submission. I also believe I
would have to rebase on top of Li Zefan's patchset that made some very
important refcount cleanups in memcg.