From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCHSET] cgroup: fix and clean up cgroup file creations and removals
Date: Fri, 28 Jun 2013 16:45:36 -0700 [thread overview]
Message-ID: <1372463145-4245-1-git-send-email-tj@kernel.org> (raw)
Hello,
cgroup has been pretty lax about errors while creating cgroupfs files.
In most cases, it just ignores the errors and continues - cgroups
created or subsystems bound under heavy memory pressure could be
missing some files. As such low memory conditions aren't too
frequent, this hasn't caused a lot of problems but this is lousy and
we'll be creating and removing cgroupfs files a lot more dynamically
with unified hierarchy. Let's get it in proper shape.
This patchset contains the following nine patches.
0001-cgroup-minor-updates-around-cgroup_clear_directory.patch
0002-cgroup-fix-error-path-of-cgroup_addrm_files.patch
0003-cgroup-fix-cgroup_add_cftypes-error-handling.patch
0004-cgroup-separate-out-cgroup_base_files-handling-out-o.patch
0005-cgroup-update-error-handling-in-cgroup_populate_dir.patch
0006-cgroup-make-rebind_subsystems-handle-file-additions-.patch
0007-cgroup-cosmetic-follow-up-cleanups.patch
0008-cgroup-move-number_of_cgroups-test-out-of-rebind_sub.patch
0009-blkcg-make-blkcg_policy_register-correctly-handle-cg.patch
0001-0007 clean up and get proper error handling implemented so that
if a file creation fails, the whole operation fails.
0008 is trivial reorganization to prepare for unified hierarchy.
0009 updates blkcg to treat cgroup_add_cftypes(), which now behaves
correctly after a failure, error properly.
This patch is on top of cgroup/for-3.11 0ce6cba357 ("cgroup:
CGRP_ROOT_SUBSYS_BOUND should be ignored when comparing mount
options") and available in the following git branc.h
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-file-error-handling
diffstat follows.
block/blk-cgroup.c | 9 +-
kernel/cgroup.c | 212 ++++++++++++++++++++++++++++++-----------------------
2 files changed, 126 insertions(+), 95 deletions(-)
Thanks.
--
tejun
next reply other threads:[~2013-06-28 23:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 23:45 Tejun Heo [this message]
[not found] ` <1372463145-4245-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-28 23:45 ` [PATCH 1/9] cgroup: minor updates around cgroup_clear_directory() Tejun Heo
[not found] ` <1372463145-4245-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 6:42 ` Li Zefan
2013-06-28 23:45 ` [PATCH 2/9] cgroup: fix error path of cgroup_addrm_files() Tejun Heo
[not found] ` <1372463145-4245-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 6:43 ` Li Zefan
2013-06-28 23:45 ` [PATCH 3/9] cgroup: fix cgroup_add_cftypes() error handling Tejun Heo
[not found] ` <1372463145-4245-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 6:43 ` Li Zefan
2013-06-28 23:45 ` [PATCH 4/9] cgroup: separate out cgroup_base_files[] handling out of cgroup_populate/clear_dir() Tejun Heo
[not found] ` <1372463145-4245-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 6:44 ` Li Zefan
2013-06-28 23:45 ` [PATCH 5/9] cgroup: update error handling in cgroup_populate_dir() Tejun Heo
[not found] ` <1372463145-4245-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 7:08 ` Li Zefan
[not found] ` <51DE59D7.2000203-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-07-11 17:01 ` Tejun Heo
[not found] ` <20130711170123.GA10195-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-12 6:36 ` Li Zefan
2013-07-11 17:18 ` [PATCH v2 " Tejun Heo
[not found] ` <20130711171825.GD10195-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-12 6:07 ` Li Zefan
2013-06-28 23:45 ` [PATCH 6/9] cgroup: make rebind_subsystems() handle file additions and removals with proper error handling Tejun Heo
[not found] ` <1372463145-4245-7-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-29 0:10 ` [PATCH v2 " Tejun Heo
2013-07-11 7:09 ` [PATCH " Li Zefan
2013-07-11 17:20 ` [PATCH v3 " Tejun Heo
[not found] ` <20130711172001.GF10195-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-12 6:13 ` Li Zefan
2013-07-12 19:37 ` [PATCH v4 " Tejun Heo
2013-06-28 23:45 ` [PATCH 7/9] cgroup: cosmetic follow-up cleanups Tejun Heo
[not found] ` <1372463145-4245-8-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-29 0:09 ` Tejun Heo
2013-07-11 7:10 ` Li Zefan
2013-06-28 23:45 ` [PATCH 8/9] cgroup: move number_of_cgroups test out of rebind_subsystems() into cgroup_remount() Tejun Heo
[not found] ` <1372463145-4245-9-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-07-11 7:10 ` Li Zefan
2013-06-28 23:45 ` [PATCH 9/9] blkcg: make blkcg_policy_register() correctly handle cgroup_add_cftypes() failures Tejun Heo
2013-07-11 17:19 ` [PATCH 5.5/9] cgroup: use for_each_subsys() instead of for_each_root_subsys() in cgroup_populate/clear_dir() Tejun Heo
[not found] ` <20130711171927.GE10195-9pTldWuhBndy/B6EtB590w@public.gmane.org>
2013-07-12 6:13 ` Li Zefan
2013-07-12 7:45 ` [PATCHSET] cgroup: fix and clean up cgroup file creations and removals Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372463145-4245-1-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).