cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hong Zhiguo <honkiko@gmail.com>
To: tj@kernel.org, vgoyal@redhat.com
Cc: cgroups@vger.kernel.org, axboe@kernel.dk,
	linux-kernel@vger.kernel.org,
	Hong Zhiguo <zhiguohong@tencent.com>
Subject: [PATCH v4 0/2] blk-throttle: simplify logic by token bucket algorithm
Date: Sun, 20 Oct 2013 20:11:10 +0800	[thread overview]
Message-ID: <1382271072-15664-1-git-send-email-zhiguohong@tencent.com> (raw)
In-Reply-To: <20131018155532.GD2277@redhat.com>

From: Hong Zhiguo <zhiguohong@tencent.com>

Based on the discussion with Vivek, Tejun and Jens.

Patch 1/2 implements basic token bucket rate limiting for blk-throttle.
Patch 2/2 adjusts some behavior for the cases pointed out by Vivek:
	- A huge bio may be allowed immediately after a long time of idle
	- When token is trimmed for above case, should not trim ancestors
	  when bio climbs up, instead, trim ancestors when bio is queued
	  on lowest child group.

Trimming of iops token is not necessary. Since a bio always costs _one_ 
iops token. Trimming it won't change the fact that current iops token is
zero or not.

I renamed "last_dispatch" back to "t_c"(Time Checkpoint, naming from network
code) because now it's not only updated when a bio is dispatched. See patch
2/2.

Thanks Vivek for the ancestor over-trim issue and the proposed solution.
I took another method inspired by Vivek's comments but different. Please
help to review it.

Hong Zhiguo (2):
  blk-throttle: simplify logic by token bucket algorithm
  blk-throttle: trim tokens generated for an idle tree

 block/blk-throttle.c | 321 ++++++++++++++-------------------------------------
 1 file changed, 87 insertions(+), 234 deletions(-)

-- 
1.8.1.2

  parent reply	other threads:[~2013-10-20 12:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12 10:46 [PATCH] blk-throttle: simplify logic by token bucket algorithm Hong Zhiguo
     [not found] ` <1381574794-7639-1-git-send-email-zhiguohong-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2013-10-13 12:59   ` Hong zhi guo
2013-10-14  9:09 ` [PATCH v2] " Hong Zhiguo
     [not found]   ` <1381741757-20888-1-git-send-email-zhiguohong-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2013-10-14 13:36     ` Tejun Heo
2013-10-14 13:47       ` Hong zhi guo
     [not found]       ` <20131014133620.GF4722-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-10-14 13:53         ` Hong zhi guo
     [not found]           ` <CAA7+ByWPM2Pizm+dP1AxPM7Ut-w=AtRfD2GkCK-0OVh+C2Twkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-14 13:59             ` Tejun Heo
     [not found]               ` <20131014135929.GH4722-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-10-15 12:35                 ` Hong zhi guo
2013-10-15 16:19                   ` Jens Axboe
2013-10-15 13:03         ` Vivek Goyal
2013-10-15 17:32     ` Vivek Goyal
2013-10-16  6:09       ` Hong zhi guo
2013-10-16 14:14         ` Vivek Goyal
2013-10-16 15:47           ` Hong zhi guo
2013-10-16 15:53           ` Tejun Heo
     [not found]             ` <20131016155344.GA10012-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-10-16 16:22               ` Vivek Goyal
2013-10-16 16:22               ` Hong zhi guo
2013-10-17 12:17 ` [PATCH v3] " Hong Zhiguo
     [not found]   ` <1382012272-26170-1-git-send-email-zhiguohong-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2013-10-18 15:55     ` Vivek Goyal
     [not found]       ` <20131018155532.GD2277-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-20 12:08         ` Hong zhi guo
2013-10-20 12:11       ` Hong Zhiguo [this message]
2013-10-20 12:11         ` [PATCH v4 1/2] " Hong Zhiguo
2014-04-10 10:07           ` Hong zhi guo
     [not found]             ` <CAA7+ByVJWjfs5HiMsnuum75egghrNQHt2KNNPTWeVa0-FWccaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-10 13:32               ` Vivek Goyal
2013-10-20 12:11         ` [PATCH v4 2/2] blk-throttle: trim tokens generated for an idle tree Hong Zhiguo
     [not found]           ` <1382271072-15664-3-git-send-email-zhiguohong-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org>
2013-10-22 21:02             ` Vivek Goyal
     [not found]               ` <20131022210232.GB2884-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-10-23  3:30                 ` Hong zhi guo
2013-10-28  5:08               ` Hong zhi guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382271072-15664-1-git-send-email-zhiguohong@tencent.com \
    --to=honkiko@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    --cc=zhiguohong@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).