From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCHSET v2 cgroup/for-3.15] cgroup: drop module support and cgroup_root_mutex
Date: Tue, 28 Jan 2014 18:43:55 -0500 [thread overview]
Message-ID: <1390952641-15950-1-git-send-email-tj@kernel.org> (raw)
Hello,
This is the second take. Changes from the last take[L] are
* Updated to reflect changes in fe1217c4f3f7 ("net: net_cls: move
cgroupfs classid handling into core").
* Rebased on top of the current linus#master + some cgroup fix
patches.
There's only one controller which makes use of the module support -
net_prio, which, non-coincidentally, isn't an actual resource
controller. It's highly unlikely that the actual resource controlling
controllers are gonna be made modular and we aren't gonna add more
non-resource controllers either, so the value of module support is
strictly restricted to the particular controller.
The controller is fairly simple while module support in cgroup core
adds quite a bit of complexity. Building the one controller as module
only saves less than half-page in vmlinux, which really can't justify
the additional complexity and (minute but existing) runtime overhead.
This patchset makes net_prio config options bool so that it can't be
built as modules and drops module support from cgroup core, which in
turn facilitates further simplification leading to removal of
cgroup_root_mutex by allowing iterating subsystems outside the
mutexes.
This patchset contains the following six patches.
0001-cgroup-make-CONFIG_CGROUP_NET_PRIO-bool-and-drop-unn.patch
0002-cgroup-drop-module-support.patch
0003-cgroup-clean-up-cgroup_subsys-names-and-initializati.patch
0004-cgroup-rename-cgroup_subsys-subsys_id-to-id.patch
0005-cgroup-update-locking-in-cgroup_show_options.patch
0006-cgroup-remove-cgroup_root_mutex.patch
0001-0002 drop cgroup module support.
0003-0004 are cleanups.
0005-0006 remove cgroup_root_mutex.
The patchset is on top of
linus#master 54c0a4b46150 ("Merge branch 'akpm' (incoming from Andrew)")
+ [1] [PATCHSET cgroup/for-3.14-fixes] cgroup: four misc fixes
+ [2] [PATCH] arm, pm, vmpressure: add missing slab.h includes
and also available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-simplify
diffstat follows. Thanks.
block/blk-cgroup.c | 9
block/blk-cgroup.h | 2
fs/bio.c | 2
include/linux/cgroup.h | 38 ---
include/linux/cgroup_subsys.h | 30 +--
include/linux/hugetlb_cgroup.h | 2
include/linux/memcontrol.h | 2
include/net/cls_cgroup.h | 2
include/net/netprio_cgroup.h | 17 -
kernel/cgroup.c | 394 ++++++-----------------------------------
kernel/cgroup_freezer.c | 8
kernel/cpuset.c | 10 -
kernel/events/core.c | 8
kernel/sched/core.c | 6
kernel/sched/cpuacct.c | 6
mm/hugetlb_cgroup.c | 9
mm/memcontrol.c | 22 +-
net/Kconfig | 2
net/core/netclassid_cgroup.c | 13 -
net/core/netprio_cgroup.c | 37 ---
net/ipv4/tcp_memcontrol.c | 2
security/device_cgroup.c | 8
22 files changed, 128 insertions(+), 501 deletions(-)
Thanks.
--
tejun
[L] http://lkml.kernel.org/g/<1389982317-22225-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[1] http://lkml.kernel.org/g/<1390923125-4369-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
[2] http://lkml.kernel.org/g/<20140128221922.GC16060-9pTldWuhBndy/B6EtB590w@public.gmane.org>
next reply other threads:[~2014-01-28 23:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 23:43 Tejun Heo [this message]
2014-01-28 23:43 ` [PATCH 2/6] cgroup: drop module support Tejun Heo
[not found] ` <1390952641-15950-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-29 4:16 ` Li Zefan
[not found] ` <52E880A6.4040902-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-01-29 15:30 ` Tejun Heo
2014-01-29 16:05 ` [PATCH v3 " Tejun Heo
[not found] ` <1390952641-15950-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-28 23:43 ` [PATCH 1/6] cgroup: make CONFIG_CGROUP_NET_PRIO bool and drop unnecessary init_netclassid_cgroup() Tejun Heo
2014-01-28 23:43 ` [PATCH 3/6] cgroup: clean up cgroup_subsys names and initialization Tejun Heo
[not found] ` <1390952641-15950-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-01-29 0:04 ` Rafael J. Wysocki
2014-01-29 8:59 ` Michal Hocko
2014-01-29 10:46 ` Peter Zijlstra
[not found] ` <20140129104648.GC9636-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2014-01-30 9:16 ` Ingo Molnar
2014-01-29 16:23 ` Aristeu Rozanski
2014-01-28 23:43 ` [PATCH 4/6] cgroup: rename cgroup_subsys->subsys_id to ->id Tejun Heo
2014-01-28 23:44 ` [PATCH 5/6] cgroup: update locking in cgroup_show_options() Tejun Heo
2014-01-29 6:32 ` [PATCHSET v2 cgroup/for-3.15] cgroup: drop module support and cgroup_root_mutex Li Zefan
2014-02-08 15:36 ` Tejun Heo
2014-01-28 23:44 ` [PATCH 6/6] cgroup: remove cgroup_root_mutex Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390952641-15950-1-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).