From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: [PATCH 1/8] cgroup: warn if "xattr" is specified with "sane_behavior" Date: Tue, 28 Jan 2014 18:59:38 -0500 Message-ID: <1390953585-16554-2-git-send-email-tj@kernel.org> References: <1390953585-16554-1-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=W7jt85SZswPfNG5WSlk03R9lasu/EKkwI5eoj9ubmpQ=; b=c/XwqeJSzMICYZIldSn/o908dXFk1xlAuer+xhF5/1E7cWY3OB9YmvmAhnaIAOQUUn w6JXJZ96CKl8ra/hBNxu9AhIrP4Zu3Oi/VljhzNwshFjh6xyNmseMXzUor6BnkhyNldN m0kIFgt5jRdT2wX5fBLDHP/wq4Ok+OL68w8jfAw+avL9D2brMdHI3m8CLkq0wMMR8sAu ezqgFkMMWE8LU3EZTEXmjEuCm9xqdr6bjTTfhFDQyn0ZmG+r+VUqi55PFo+Et0rIOWTG Z9WaUkrzQm3D5XWEGO4uDTykZdEURgrG7RJNrzXw5llQDu4gwRJ3DHgyfUecj3jmNO2A NPUA== In-Reply-To: <1390953585-16554-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Cc: Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Mount option "xattr" is no longer necessary as it's enabled by default on kernfs. Warn if "xattr" is specified with "sane_behavior" so that the option can be removed in the future. Signed-off-by: Tejun Heo --- include/linux/cgroup.h | 2 ++ kernel/cgroup.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index b6c2652..6fe238e 100644 --- a/include/linux/cgroup.h +++ b/include/linux/cgroup.h @@ -262,6 +262,8 @@ enum { * - "release_agent" and "notify_on_release" are removed. * Replacement notification mechanism will be implemented. * + * - "xattr" mount option is deprecated. kernfs always enables it. + * * - cpuset: tasks will be kept in empty cpusets when hotplug happens * and take masks of ancestors with non-empty cpus/mems, instead of * being moved to an ancestor. diff --git a/kernel/cgroup.c b/kernel/cgroup.c index e60a5e3..056bd7d 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -1265,6 +1265,9 @@ static int parse_cgroupfs_options(char *data, struct cgroup_sb_opts *opts) pr_err("cgroup: sane_behavior: clone_children is not allowed\n"); return -EINVAL; } + + if (opts->flags & CGRP_ROOT_XATTR) + pr_warning("cgroup: sane_behavior: xattr is always available, flag unnecessary\n"); } /* -- 1.8.5.3