From mboxrd@z Thu Jan 1 00:00:00 1970 From: Monam Agarwal Subject: [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in cgroup.c Date: Mon, 24 Mar 2014 00:17:18 +0530 Message-ID: <1395600438-9838-1-git-send-email-monamagarwal123@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=briO3o/FnLage+F0Yu2d896o1m+xIlGnP4FQ3MFrGlg=; b=eODT4KslOj8096sHdKyLCulovMEsA8qs3UuAGsl7Jy/9ynDVrXVaBF8hi0Xzae7wCX 8JvDp1lSsPeSPn0ebp6tHPabkoRoev1rI8Q8Wo3y2dI3nB7hPgInIUT0FvnyYtV0l78F fYRDn4YX80wlArsNiN4v10+0jHBox/cKmZ0hwA2R0kmXXpqVudj/9R851T25osphxW80 LKK+E/cppk3lJ5SfHJ3zGmPFpcpQNB3S5TN5rBH34cIlAbG6Z2TrjhhMmpbeJqCkOrSb 1cv00Ndu/pu+yLFUGcLFKhAhG8Cl2cbDdjAb+LHgtsQM9fc2jaHF2obEwyKaDa7b+0yZ 1U7w== List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) Signed-off-by: Monam Agarwal --- kernel/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 105f273..3462f62 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ -4033,7 +4033,7 @@ static void css_release(struct percpu_ref *ref) struct cgroup_subsys_state *css = container_of(ref, struct cgroup_subsys_state, refcnt); - rcu_assign_pointer(css->cgroup->subsys[css->ss->subsys_id], NULL); + RCU_INIT_POINTER(css->cgroup->subsys[css->ss->subsys_id], NULL); call_rcu(&css->rcu_head, css_free_rcu_fn); } -- 1.7.9.5