public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <llong@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Waiman Long <llong@redhat.com>,
	Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Marco Crivellari <marco.crivellari@suse.com>,
	cgroups@vger.kernel.org
Subject: Re: [PATCH 1/2] genirq: Fix IRQ threads affinity VS cpuset isolated partitions
Date: Tue, 18 Nov 2025 12:29:22 -0500	[thread overview]
Message-ID: <13bfb066-dc00-43a7-a84b-e70df62173bd@redhat.com> (raw)
In-Reply-To: <87h5urmez6.ffs@tglx>


On 11/18/25 12:23 PM, Thomas Gleixner wrote:
> On Tue, Nov 18 2025 at 11:27, Waiman Long wrote:
>>> +static inline void irq_thread_set_affinity(struct task_struct *t,
>>> +					   struct irq_desc *desc)
>>> +{
>>> +	kthread_bind_mask(t, irq_data_get_effective_affinity_mask(&desc->irq_data));
>>> +}
>> According to irq_thread_check_affinity(), accessing the cpumask returned
>> from irq_data_get_effective_affinity_mask(&desc->irq_data) requires
>> taking desc->lock to ensure its stability. Do we need something similar
>> here? Other than that, it looks good to me.
> That's during interrupt setup so it should be stable (famous last words)

Thanks for the clarification. We should probably add a comment to 
mention that.

Cheers,
Longman


  reply	other threads:[~2025-11-18 17:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 14:30 [PATCH 0/2] genirq: Fix IRQ threads VS cpuset Frederic Weisbecker
2025-11-18 14:30 ` [PATCH 1/2] genirq: Fix IRQ threads affinity VS cpuset isolated partitions Frederic Weisbecker
2025-11-18 16:27   ` Waiman Long
2025-11-18 17:23     ` Thomas Gleixner
2025-11-18 17:29       ` Waiman Long [this message]
2025-11-20 11:51   ` Marek Szyprowski
2025-11-20 13:20     ` Frederic Weisbecker
2025-11-20 15:00       ` Thomas Gleixner
2025-11-20 15:50         ` Frederic Weisbecker
2025-11-20 19:09           ` Thomas Gleixner
2025-11-20 16:34         ` Marek Szyprowski
2025-11-20 13:45     ` Thomas Gleixner
2025-11-18 14:30 ` [PATCH 2/2] genirq: Remove cpumask availability check on kthread affinity setting Frederic Weisbecker
2025-11-18 15:14 ` [PATCH 0/2] genirq: Fix IRQ threads VS cpuset Thomas Gleixner
2025-11-18 17:44   ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13bfb066-dc00-43a7-a84b-e70df62173bd@redhat.com \
    --to=llong@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox