From: Jason Low <jason.low2-VXdhtT5mjnY@public.gmane.org>
To: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
aswin-VXdhtT5mjnY@public.gmane.org,
scott.norton-VXdhtT5mjnY@public.gmane.org,
chegu_vinod-VXdhtT5mjnY@public.gmane.org,
jason.low2-VXdhtT5mjnY@public.gmane.org
Subject: Re: [RFC][PATCH] cpuset, sched: Fix cpuset sched_relax_domain_level
Date: Fri, 30 Jan 2015 10:35:21 -0800 [thread overview]
Message-ID: <1422642921.3365.1.camel@j-VirtualBox> (raw)
In-Reply-To: <54CB04DC.3090405-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, 2015-01-30 at 12:13 +0800, Zefan Li wrote:
> On 2015/1/29 4:47, Jason Low wrote:
> > The cpuset.sched_relax_domain_level can control how far we do
> > immediate load balancing on a system. However, it was found on recent
> > kernels that echo'ing a value into cpuset.sched_relax_domain_level
> > did not reduce any immediate load balancing.
> >
> > The reason this occurred was because the update_domain_attr_tree() traversal
> > did not update for the "top_cpuset". This resulted in nothing being changed
> > when modifying the sched_relax_domain_level parameter.
> >
> > This patch was able to address that problem by having update_domain_attr_tree()
> > allowing updates for the root (top_cpuset) in the cpuset traversal.
> >
> > Signed-off-by: Jason Low <jason.low2-VXdhtT5mjnY@public.gmane.org>
>
> Thanks for finding this bug!
>
> Please Add:
>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # 3.9+
> Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()")
Okay, I will send out a new version.
Thanks,
Jason
prev parent reply other threads:[~2015-01-30 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 20:47 [RFC][PATCH] cpuset, sched: Fix cpuset sched_relax_domain_level Jason Low
2015-01-30 4:13 ` Zefan Li
[not found] ` <54CB04DC.3090405-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-01-30 18:35 ` Jason Low [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422642921.3365.1.camel@j-VirtualBox \
--to=jason.low2-vxdhtt5mjny@public.gmane.org \
--cc=aswin-VXdhtT5mjnY@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=chegu_vinod-VXdhtT5mjnY@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=scott.norton-VXdhtT5mjnY@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).