public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [PATCH 1/1] cgroup: fix var may be used uninitialized warning
Date: Tue,  3 Mar 2015 09:59:47 +0100	[thread overview]
Message-ID: <1425373187-7227-1-git-send-email-javier.martinez@collabora.co.uk> (raw)

When building cgroup, GCC warns that the root variable
may be used uninitialized in the cgroup_mount function.

kernel/cgroup.c: In function ‘cgroup_mount’:
kernel/cgroup.c:1886:13: warning: ‘root’ may be used uninitialized in this function [-Wuninitialized]
kernel/cgroup.c:1742:22: note: ‘root’ was declared here

This can never happen because if the struct cgroup_root
can't be allocated, ret is set to -ENOMEM and the error
returned so the code using root is not reachable. But
set root to NULL just to silence the compiler warning.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---

This patch is on top of today's linux-next (tag: next-20150303).

 kernel/cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 9a567836ee3a..bf1172d1c831 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1739,7 +1739,7 @@ static struct dentry *cgroup_mount(struct file_system_type *fs_type,
 {
 	struct super_block *pinned_sb = NULL;
 	struct cgroup_subsys *ss;
-	struct cgroup_root *root;
+	struct cgroup_root *root = NULL;
 	struct cgroup_sb_opts opts;
 	struct dentry *dentry;
 	int ret;
-- 
2.1.3

             reply	other threads:[~2015-03-03  8:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  8:59 Javier Martinez Canillas [this message]
     [not found] ` <1425373187-7227-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-03-03 13:46   ` [PATCH 1/1] cgroup: fix var may be used uninitialized warning Tejun Heo
     [not found]     ` <20150303134642.GD3122-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2015-03-03 15:12       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425373187-7227-1-git-send-email-javier.martinez@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox