Re: [PATCH v10 1/4] cgroups: use bitmask to filter for_each_subsys

Aleksa Sarai
2015-05-13T05:44:51Z

Hi Tejun,

> Hmmmm... You can either convert all masks to ulong (which is fine) or
> do something like the following.
>
> #define for_each_subsys_which(ss_mask, ss, ssid) \
> unsigned long __tmp_mask = (ss_mask); \
> for_each_set_bit(ssid, &__tmp_mask, CGROUP_SUBSYS_COUNT)\
> if ((ss) = group_subsys[ssid] && false) \
> ; \
> else

I think I'll just do casting and manually make new variables where
required. The above (and similar) doesn't work very well, generates
warnings like crazy and breaks stuff like:

if (...)
for_each_subsys_which(...)

--
Aleksa Sarai (cyphar)