From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: [PATCHSET v2 block/for-4.3] block, cgroup: make cfq charge async IOs to the appropriate blkcgs
Date: Tue, 7 Jul 2015 11:35:52 -0400 [thread overview]
Message-ID: <1436283361-3889-1-git-send-email-tj@kernel.org> (raw)
Hello,
This is v2 of cfq cgroup writeback patchset. Changes from the last
take[L] are
* Switched from GFP_ATOMIC to GFP_NOWAIT as suggested by Jeff.
* Other misc review points addressed, acks added and rebased.
cfq has always charged all async IOs to the root cgroup. It didn't
have much choice as writeback didn't know about cgroups and there was
no way to tell who to blame for a given writeback IO. writeback
finally grew support for cgroups and now tags each writeback IO with
the appropriate cgroup to charge it against.
This patchset updates cfq so that it follows the blkcg each bio is
tagged with. Async cfq_queues are now shared across cfq_group, which
is per-cgroup, instead of per-request_queue cfq_data. This makes all
IOs follow the weight based IO resource distribution implemented by
cfq.
This patchset contains the following 8 patches.
0001-cfq-iosched-simplify-control-flow-in-cfq_get_queue.patch
0002-cfq-iosched-fix-async-oom-queue-handling.patch
0003-cfq-iosched-fix-oom-cfq_queue-ref-leak-in-cfq_set_re.patch
0004-cfq-iosched-minor-cleanups.patch
0005-blkcg-cfq-iosched-use-GFP_NOWAIT-instead-of-GFP_ATOM.patch
0006-cfq-iosched-remove-gfp_mask-from-cfq_find_alloc_queu.patch
0007-cfq-iosched-move-cfq_group-determination-from-cfq_fi.patch
0008-cfq-iosched-fold-cfq_find_alloc_queue-into-cfq_get_q.patch
0009-cfq-iosched-charge-async-IOs-to-the-appropriate-blkc.patch
0001-0003 are a prep and two fix patches on top. The bugs fixed by
these patches are very unlikely to cause problems in actual usage, so
the patches aren't tagged w/ -stable.
0004-0008 are prep patches.
0009 makes cfq cgroup-writeback ready.
This patchset is on top of
d770e558e219 ("Linux 4.2-rc1")
+ [1] [PATCHSET block/for-4.3] writeback: cgroup writeback updates
diffstat follows, thanks.
block/blk-cgroup.c | 8 -
block/cfq-iosched.c | 220 ++++++++++++++++++++--------------------------------
2 files changed, 89 insertions(+), 139 deletions(-)
--
tejun
[L] http://lkml.kernel.org/g/1433753973-23684-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[1] http://lkml.kernel.org/g/1436281823-1947-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
next reply other threads:[~2015-07-07 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 15:35 Tejun Heo [this message]
2015-07-07 15:35 ` [PATCH 2/9] cfq-iosched: fix async oom queue handling Tejun Heo
2015-07-07 15:35 ` [PATCH 3/9] cfq-iosched: fix oom cfq_queue ref leak in cfq_set_request() Tejun Heo
[not found] ` <1436283361-3889-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-07-07 15:35 ` [PATCH 1/9] cfq-iosched: simplify control flow in cfq_get_queue() Tejun Heo
2015-07-07 15:35 ` [PATCH 4/9] cfq-iosched: minor cleanups Tejun Heo
2015-07-07 15:36 ` [PATCH 8/9] cfq-iosched: fold cfq_find_alloc_queue() into cfq_get_queue() Tejun Heo
2015-07-07 15:36 ` [PATCH 9/9] cfq-iosched: charge async IOs to the appropriate blkcg's instead of the root Tejun Heo
2015-07-07 15:35 ` [PATCH 5/9] blkcg, cfq-iosched: use GFP_NOWAIT instead of GFP_ATOMIC for non-critical allocations Tejun Heo
2015-07-07 15:35 ` [PATCH 6/9] cfq-iosched: remove @gfp_mask from cfq_find_alloc_queue() Tejun Heo
2015-07-07 15:35 ` [PATCH 7/9] cfq-iosched: move cfq_group determination from cfq_find_alloc_queue() to cfq_get_queue() Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436283361-3889-1-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).