cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org
Subject: [PATCHSET cgroup,block/for-4.3] cgroup, blkcg: establish controller interface conventions
Date: Sun,  2 Aug 2015 16:23:40 -0400	[thread overview]
Message-ID: <1438547024-23497-1-git-send-email-tj@kernel.org> (raw)

Hello,

On the legacy hierarchies, different controllers implemented interface
without much guidance and as a result there isn't much consistency
across controllers even when they're doing similar things.

Controllers which already implemented interface for the unified
hierarchy are already pretty consistent and this patchset explicitly
sets up the conventions so that it's easier to make future conversions
conformant.

For blkcg, the only thing which needs to be changed is the range and
default value of io.weight which is currently [10, 1000] and 500.  For
the unified hierarchy, cgroup now defines the standard range and
default value to be [1, 10000] and 100 so that there's enough room for
100x bias in both directions.

This patchset contains the following four patches.

 0001-cgroup-export-cgrp_dfl_root.patch
 0002-cgroup-define-controller-file-conventions.patch
 0003-blkcg-s-CFQ_WEIGHT_-CFQ_WEIGHT_LEGACY_.patch
 0004-blkcg-use-CGROUP_WEIGHT_-scale-for-io.weight-on-the-.patch

0001-0002 explicitly defines the controller interface file conventions
on the unified hierarchy.  0003-0004 update blkcg so that it conforms
to the standard weight range.

This patchset is also available in the following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-blkcg-normalize-weight

and is on top of

  block/for-linus f3f5da624e0a ("block: Do a full clone when splitting discard bios")
+ [1] [PATCHSET block/for-4.3] writeback: cgroup writeback updates
+ [2] [PATCHSET v2 block/for-4.3] block, cgroup: make cfq charge async IOs to the appropriate blkcgs
+ [3] [PATCHSET v3 block/for-4.3] blkcg: blkcg policy methods and data handling cleanup
+ [4] [PATCHSET v2 block/for-4.3] blkcg: blkcg stats cleanup
+ [5] [PATCHSET block/for-4.3] blkcg: implement interface for the unified hierarchy

diffstat follows.  Thanks.

 Documentation/cgroups/unified-hierarchy.txt |   77 ++++++++++++++++++++++++----
 block/blk-cgroup.c                          |   21 +++++++
 block/cfq-iosched.c                         |   63 ++++++++++++++++------
 include/linux/blk-cgroup.h                  |    2 
 include/linux/cgroup.h                      |    9 +++
 kernel/cgroup.c                             |    1 
 6 files changed, 145 insertions(+), 28 deletions(-)

--
tejun

[L] http://lkml.kernel.org/g/1435268337-1738-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[1] http://lkml.kernel.org/g/1436281823-1947-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[2] http://lkml.kernel.org/g/1436283361-3889-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[3] http://lkml.kernel.org/g/1436637654-28110-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[4] http://lkml.kernel.org/g/1436724043-12986-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
[5] http://lkml.kernel.org/g/1437763434-28699-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

             reply	other threads:[~2015-08-02 20:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-02 20:23 Tejun Heo [this message]
2015-08-02 20:23 ` [PATCH 1/4] cgroup: export cgrp_dfl_root Tejun Heo
     [not found]   ` <1438547024-23497-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-08-05  8:18     ` Zefan Li
2015-08-05 20:23     ` Tejun Heo
2015-08-02 20:23 ` [PATCH 2/4] cgroup: define controller file conventions Tejun Heo
     [not found]   ` <1438547024-23497-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-08-03 13:36     ` Johannes Weiner
2015-08-05  8:19   ` Zefan Li
2015-08-02 20:23 ` [PATCH 3/4] blkcg: s/CFQ_WEIGHT_*/CFQ_WEIGHT_LEGACY_*/ Tejun Heo
     [not found] ` <1438547024-23497-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-08-02 20:23   ` [PATCH 4/4] blkcg: use CGROUP_WEIGHT_* scale for io.weight on the unified hierarchy Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438547024-23497-1-git-send-email-tj@kernel.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kernel-team-b10kYP2dOMg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).