cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	tytso@mit.edu, dedekind1@gmail.com, decui@microsoft.com,
	kernel-team@fb.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback()
Date: Tue, 29 Sep 2015 12:47:51 -0400	[thread overview]
Message-ID: <1443545274-18787-3-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1443545274-18787-1-git-send-email-tj@kernel.org>

wakeup_dirtytime_writeback() walks and wakes up all wb's of all bdi's;
unfortunately, it was always waking up bdi->wb instead of the wb being
walked.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 001fe6f617b1 ("writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's")
---
 fs/fs-writeback.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 091a364..d0da306 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1897,8 +1897,8 @@ static void wakeup_dirtytime_writeback(struct work_struct *w)
 		struct wb_iter iter;
 
 		bdi_for_each_wb(wb, bdi, &iter, 0)
-			if (!list_empty(&bdi->wb.b_dirty_time))
-				wb_wakeup(&bdi->wb);
+			if (!list_empty(&wb->b_dirty_time))
+				wb_wakeup(wb);
 	}
 	rcu_read_unlock();
 	schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ);
-- 
2.4.3

  reply	other threads:[~2015-09-29 16:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 16:47 [PATCHSET block/for-linus] writeback: cgroup writeback fixes Tejun Heo
2015-09-29 16:47 ` Tejun Heo [this message]
     [not found]   ` <1443545274-18787-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-10-02 14:12     ` [PATCH 2/5] writeback: fix bdi_writeback iteration in wakeup_dirtytime_writeback() Jan Kara
     [not found] ` <1443545274-18787-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-29 16:47   ` [PATCH 1/5] writeback: laptop_mode_timer_fn() needs rcu_read_lock() around bdi_writeback iteration Tejun Heo
     [not found]     ` <1443545274-18787-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-10-02 14:13       ` Jan Kara
2015-09-29 16:47   ` [PATCH 3/5] writeback: bdi_writeback iteration must not skip dying ones Tejun Heo
     [not found]     ` <1443545274-18787-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-10-02 14:12       ` Jan Kara
     [not found]         ` <20151002141212.GA17746-+0h/O2h83AeN3ZZ/Hiejyg@public.gmane.org>
2015-10-02 18:19           ` Tejun Heo
2015-10-02 18:47     ` [PATCH v2 " Tejun Heo
2015-09-29 16:47   ` [PATCH 4/5] writeback: memcg dirty_throttle_control should be initialized with wb->memcg_completions Tejun Heo
2015-09-29 16:47   ` [PATCH 5/5] writeback: fix incorrect calculation of available memory for memcg domains Tejun Heo
     [not found]     ` <1443545274-18787-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-29 17:04       ` [PATCH v2 " Tejun Heo
2015-09-29 16:50   ` [PATCHSET block/for-linus] writeback: cgroup writeback fixes Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443545274-18787-3-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=decui@microsoft.com \
    --cc=dedekind1@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).