From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: [PATCHSET RFC cgroup/for-4.6] cgroup, sched: implement resource group and PRIO_RGRP Date: Sat, 09 Apr 2016 08:16:43 +0200 Message-ID: <1460182603.3765.155.camel@gmail.com> References: <1457710888-31182-1-git-send-email-tj@kernel.org> <20160314113013.GM6344@twins.programming.kicks-ass.net> <20160406155830.GI24661@htj.duckdns.org> <20160407064549.GH3430@twins.programming.kicks-ass.net> <20160407073547.GA12560@cmpxchg.org> <20160407080833.GK3430@twins.programming.kicks-ass.net> <20160407194555.GI7822@mtj.duckdns.org> <20160407202542.GD3448@twins.programming.kicks-ass.net> <20160408201135.GO24661@htj.duckdns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Am4y/KnuiLJJS9706d7oxANOObmjKrOXKCS/1dzo+dQ=; b=Aw9tINS2vutlZBUwR4EoW+3xSapZeIe8bdN93nWJg1LPi2Ssj4RSLhqCFJ8mAJGdC3 5fnr6k9LffrwOqqkAxh5EXxmfGz+dA/S71xOriWKgZhSGV/tWhVJhTn53hqP2t6BgUsD qbci6GUWCIU4DmXBw32HZrucIh2HIgcnNbrxbt0Lv1UYB16m/Bd0w9BSQUtRJL9hjkGV diDDIW6bLUN0DzTaPDVfPnzot1y9z2JxkKWVoOoyD7aO7Iq4z+b018Jl843lCiY5NhfP 4CkCweViApwP/undVJ6XfShVPqWt6tbPCkuyZJuR0pkx918WQ8AjvwfZEXutjVHL4JLX +QMQ== In-Reply-To: <20160408201135.GO24661-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo , Peter Zijlstra Cc: Johannes Weiner , torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-team-b10kYP2dOMg@public.gmane.org On Fri, 2016-04-08 at 16:11 -0400, Tejun Heo wrote: > > That's just plain broken... That is not how a proportional weight based > > hierarchical controller works. > > That's a strong statement. When the hierarchy is composed of > equivalent objects as in CPU, not distinguishing internal and leaf > nodes would be a more natural way to organize; however... You almost said it yourself, you want to make the natural organization of cpu, cpuacct and cpuset controllers a prohibited organization. There is no "however..." that can possibly justify that. It's akin to mandating: henceforth "horse" shall be spelled "cow", riders thereof shall teach their "cow" the proper enunciation of "moo". It's silly. Like it or not, these controllers have thread encoded in their DNA, it's an integral part of what they are, and how real users in the real world use them. No rationalization will change that cold hard fact. Make an "Aunt Tilly" button for those incapable of comprehending the complexities if you will, but please don't make cgroups so rigid and idiot proof that only idiots (hi system thing) can use it. -Mike