From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: [PATCHSET RFC cgroup/for-4.6] cgroup, sched: implement resource group and PRIO_RGRP Date: Thu, 14 Apr 2016 08:07:37 +0200 Message-ID: <1460614057.5100.150.camel@gmail.com> References: <20160406155830.GI24661@htj.duckdns.org> <20160407064549.GH3430@twins.programming.kicks-ass.net> <20160407073547.GA12560@cmpxchg.org> <20160407080833.GK3430@twins.programming.kicks-ass.net> <20160407194555.GI7822@mtj.duckdns.org> <20160407202542.GD3448@twins.programming.kicks-ass.net> <20160408201135.GO24661@htj.duckdns.org> <20160409133917.GV3448@twins.programming.kicks-ass.net> <20160412222915.GT24661@htj.duckdns.org> <1460533381.3780.191.camel@gmail.com> <20160413155952.GU24661@htj.duckdns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=kxlep/yTKUSCEtsEOoMViwtr6vP/4awqVd66GtwTnUo=; b=V+3S9ygj21a4AzBgvZWevPnsjadsvHFV3HZEeFi8KCNaOgSW4BSEP9PAx8w9nAsTfa fgQ/BlNKcJAi8rYol7wHv4isVWV2kmBcY4PnrLOazTv/AX6QLHAQiIXXOgMaSev6TyU8 5HHh4owFLki9CJkyiLRj1lMq6PO+SiKkBSDDN29tprNFvzmqV5HiLMa7g2WAzv658HBS 6gaAfwk9OACeLjWS1NaqTkmRNY2Ju/qXAnb2DOaGvKFfezWNsI1bNZptcp8Ixs3RrUmW IGWSKkdvrQ7t8eYrtWYTxia/y84+DkH6E9rCb95kNRUlVLWTEOSZqJa7g/rC+gIvdv4J NmiQ== In-Reply-To: <20160413155952.GU24661@htj.duckdns.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Tejun Heo Cc: Peter Zijlstra , Johannes Weiner , torvalds@linux-foundation.org, akpm@linux-foundation.org, mingo@redhat.com, lizefan@huawei.com, pjt@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-api@vger.kernel.org, kernel-team@fb.com On Wed, 2016-04-13 at 11:59 -0400, Tejun Heo wrote: > Hello, Mike. > > On Wed, Apr 13, 2016 at 09:43:01AM +0200, Mike Galbraith wrote: > > > The cost is part aesthetical and part practical. While less > > > elegant > > > than tree of uniform objects, it seems a stretch to call internal > > > / > > > leaf node distinction broken especially given that the model is > > > natural to some controllers. > > > > That justifies prohibiting proper usages of three controllers, cpu, > > cpuacct and cpuset? > > Neither cpuacct or cpuset loses any capability from the constraint as > there is no difference between tasks being in an internal cgroup or a > leaf cgroup nested under it. The only practical impact is that we > lose the ability to let internal tasks compete against sibling cgroups > for proportional control. I'm not getting it. A. entity = task[s] | cgroup[s] B. entity = task[s] ^ cgroup[s] A I get, B I don't, but you seem to be saying B, else we get the task competes with sibling cgroup business. Let /foo be an exclusive cpuset containing exclusive subset bar. How can any task acquire set foo affinity if B really really applies? My box calls me a dummy if I try to create a "proper" home for tasks, one with both no snobby neighbors and proper affinity. -Mike