From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH] cgroup: Show control files in cgroup2 root after mount
Date: Tue, 18 Jul 2017 15:32:16 -0400 [thread overview]
Message-ID: <1500406336-29512-1-git-send-email-longman@redhat.com> (raw)
It was found that when a cgroup2 filesystem was mounted, control
files other than the base cgroup.* ones were not shown in the root
directory. They were shown only after some controllers were activated
in the root's cgroup.subtree_control file.
This was caused by a lack of the kernfs_activate() call which was fixed
by this patch.
Signed-off-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
kernel/cgroup/cgroup.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 89a23c6..fb1893b 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2024,8 +2024,10 @@ static struct dentry *cgroup_mount(struct file_system_type *fs_type,
dentry = cgroup_do_mount(&cgroup2_fs_type, flags, &cgrp_dfl_root,
CGROUP2_SUPER_MAGIC, ns);
- if (!IS_ERR(dentry))
+ if (!IS_ERR(dentry)) {
apply_cgroup_root_flags(root_flags);
+ kernfs_activate(cgrp_dfl_root.cgrp.kn);
+ }
} else {
dentry = cgroup1_mount(&cgroup_fs_type, flags, data,
CGROUP_SUPER_MAGIC, ns);
--
1.8.3.1
next reply other threads:[~2017-07-18 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 19:32 Waiman Long [this message]
[not found] ` <1500406336-29512-1-git-send-email-longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-18 19:51 ` [PATCH] cgroup: Show control files in cgroup2 root after mount Tejun Heo
[not found] ` <20170718195148.GC3365493-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-07-18 20:00 ` Waiman Long
[not found] ` <539870d2-8b85-2f54-61bd-4ba068e75ce0-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-18 20:12 ` Tejun Heo
2017-07-18 20:29 ` Waiman Long
[not found] ` <255cc198-2c10-af76-98ca-086807d11540-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-18 20:50 ` Tejun Heo
2017-07-18 21:06 ` Tejun Heo
2017-07-18 21:57 ` [PATCH cgroup/for-4.13-fixes] cgroup: create dfl_root files on subsys registration Tejun Heo
[not found] ` <20170718215746.GG3365493-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-07-18 22:09 ` Waiman Long
[not found] ` <d44b7b53-0be6-7019-169a-aa45b4d02598-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-07-18 22:11 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500406336-29512-1-git-send-email-longman@redhat.com \
--to=longman-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox