Re: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to huge_memory.c

Alex Shi
2020-03-04T08:13:43Z

ÔÚ 2020/3/4 ÏÂÎç3:47, Kirill A. Shutemov Ð´µÀ:
> On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote:
>> The func is only used in huge_memory.c, defining it in other file with a
>> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird.
>>
>> Let's move it close user.
>
> I don't think it's strong enough justification. I would rather keep all
> lru helpers in one place.
>

Thanks for comments, Kirill,

If it's a common used func, yes.

But if you look into details of this func, it's thp used only func.

Thanks
Alex