Re: [PATCH v9 02/20] mm/memcg: fold lock_page_lru into commit_charge

Alex Shi
2020-03-04T07:19:46Z

ÔÚ 2020/3/4 ÉÏÎç11:13, Hillf Danton Ð´µÀ:
>> * Nobody should be changing or seriously looking at
>> * page->mem_cgroup at this point:
>> @@ -2633,8 +2611,13 @@ static void commit_charge(struct page *page, struct mem_cgroup *memcg,
>> */
>> page->mem_cgroup = memcg;
>>
> Well it is likely to update memcg for page without lru_lock held even if
> more care is required, which is a change added in the current semantic and
> worth a line of words in log.
>

the lru_lock is guard for lru list, not for page->mem_cgroup, seem no need to highlight this point. Do we?

Thanks
Alex