public inbox for cgroups@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
To: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Vladimir Davydov
	<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [Resend PATCH 2/6] mm/memcg: remove useless check on page->mem_cgroup
Date: Tue, 11 Aug 2020 19:10:28 +0800	[thread overview]
Message-ID: <1597144232-11370-2-git-send-email-alex.shi@linux.alibaba.com> (raw)
In-Reply-To: <1597144232-11370-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>

If we disabled memcg by cgroup_disable=memory, the swap charges are
still called. Let's return from the funcs earlier and keep WARN_ON
monitor.

Signed-off-by: Alex Shi <alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
Reviewed-by: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
Acked-by: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Vladimir Davydov <vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 mm/memcontrol.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 299382fc55a9..419cf565f40b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7098,6 +7098,9 @@ void mem_cgroup_swapout(struct page *page, swp_entry_t entry)
 	VM_BUG_ON_PAGE(PageLRU(page), page);
 	VM_BUG_ON_PAGE(page_count(page), page);
 
+	if (mem_cgroup_disabled())
+		return;
+
 	if (cgroup_subsys_on_dfl(memory_cgrp_subsys))
 		return;
 
@@ -7163,6 +7166,9 @@ int mem_cgroup_try_charge_swap(struct page *page, swp_entry_t entry)
 	struct mem_cgroup *memcg;
 	unsigned short oldid;
 
+	if (mem_cgroup_disabled())
+		return 0;
+
 	if (!cgroup_subsys_on_dfl(memory_cgrp_subsys))
 		return 0;
 
-- 
1.8.3.1


  parent reply	other threads:[~2020-08-11 11:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 11:10 [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Alex Shi
     [not found] ` <1597144232-11370-1-git-send-email-alex.shi-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-11 11:10   ` Alex Shi [this message]
2020-08-11 11:30     ` [Resend PATCH 2/6] mm/memcg: remove useless check on page->mem_cgroup Michal Hocko
     [not found]       ` <20200811113008.GK4793-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-11 12:42         ` Alex Shi
2020-08-11 12:54         ` Alex Shi
     [not found]           ` <776b0e6f-4129-9fb9-0f66-47757cf320d5-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-11 13:56             ` Michal Hocko
2020-08-12  3:25               ` Alex Shi
     [not found]                 ` <0b5e1ac3-c9c7-35e9-2661-b58430314d0a-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13  6:20                   ` Michal Hocko
     [not found]                     ` <20200813062049.GA9477-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-13  9:45                       ` Alex Shi
     [not found]                         ` <abd9276b-31f8-a51d-43d6-6c8ae93237dc-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-13 11:01                           ` Michal Hocko
2020-08-20 14:58   ` [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged Qian Cai
     [not found]     ` <20200820145850.GA4622-J5quhbR+WMc@public.gmane.org>
2020-08-21  8:01       ` Michal Hocko
     [not found]         ` <20200821080127.GD32537-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-21 12:39           ` Qian Cai
2020-08-21 13:48             ` Michal Hocko
     [not found]               ` <20200821134842.GF32537-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-21 14:01                 ` Qian Cai
2020-08-24 15:10                 ` Michal Hocko
     [not found]                   ` <20200824151013.GB3415-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-25  1:25                     ` Alex Shi
     [not found]                       ` <12425e06-38ce-7ff4-28ce-b0418353fc67-KPsoFbNs7GizrGE5bRqYAgC/G2K4zDHf@public.gmane.org>
2020-08-25  2:04                         ` Hugh Dickins
     [not found]                           ` <alpine.LSU.2.11.2008241849020.1171-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2020-08-27  6:00                             ` Hugh Dickins
2020-08-25  7:25                         ` Michal Hocko
2020-08-24 14:52       ` Qian Cai
     [not found]         ` <20200824145201.GB4337-J5quhbR+WMc@public.gmane.org>
2020-08-24 15:10           ` Michal Hocko
     [not found]             ` <20200824151045.GC3415-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-08-24 23:00               ` Stephen Rothwell
     [not found]                 ` <20200825090054.3c5dd68a-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2020-08-24 23:14                   ` Alex Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1597144232-11370-2-git-send-email-alex.shi@linux.alibaba.com \
    --to=alex.shi-kpsofbns7gizrge5brqyagc/g2k4zdhf@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox