From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v4 0/5] cgroup/cpuset: Fix CLONE_INTO_CGROUP problem & other issues Date: Wed, 12 Apr 2023 14:29:46 -0400 Message-ID: <168bb07f-844f-13f5-e4bd-77c2cec94046@redhat.com> References: <20230411133601.2969636-1-longman@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681324195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MWy6sv13whg9JBQjJjQUf4sYt60lbACx2Lp0OS4PkY8=; b=D5l7WUWTCLSZCk29NeBNCBzDz0QoAY5/Ytj4T/OOvyGUeD41Oq0qv6EzZiPkxBbozE0jEm XVpfMyA2JJ6/O054VXCCrRLLJjRV3NqyKDLpR/PUYGHods4+wQJbKm16R+y8AOGxtH1qqJ Eu9TcZF/SnznlJRaf4dGG71QncidKkA= Content-Language: en-US In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: Zefan Li , Johannes Weiner , Christian Brauner , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Juri Lelli , Dietmar Eggemann , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Giuseppe Scrivano On 4/12/23 14:26, Tejun Heo wrote: > On Tue, Apr 11, 2023 at 09:35:56AM -0400, Waiman Long wrote: >> v4: >> - Add missing rcu_read_lock/unlock to cpuset_cancel_fork() in patch 3. >> - Add patch 5 to reduce performance impact for the >> non-CLONE_INTO_CGROUP case. >> >> v3: >> - Update patches 2 & 3 to put task_cs() call under rcu_read_lock(). >> >> v2: >> - Drop v1 patch 3 >> - Add a new patch to fix an issue in cpuset_cancel_attach() and >> another patch to add cpuset_can_fork() and cpuset_cacnel_fork() >> methods. >> >> The first patch in this series fixes a problem in >> cpuset_cancel_attach(). Patches 2 and 3 fixes the CLONE_INTO_CGROUP >> problem in cpuset. Patch 4 is a minor fix. The last patch is a >> performance optimization patch for the non-CLONE_INTO_CGROUP case. > Applied 1-4 to cgroup/for-6.3-fixes w/ stable cc'd. Given that the fixes are > a bit involved, the breakages have been there for quite a while and the > cpuset code has changed quite a bit, backporting might not be trivial tho. > Let's see how that goes. I know stable backport won't be straight forward. I am planning to help in the backporting effort. Thanks for taking these into your cgroup tree. Cheers, Longman