From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85EAE27A462; Mon, 15 Jun 2026 10:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781517704; cv=none; b=SWutcFS8xePco3Oay5GdhyDHzSKJRavzVsdjx48fEQ9UryuftLtzTdabx8eOU4JXQZu0adKAIFhlZ+L5sj0mfJjf9KK3uDjqcvJd8zMVHnvjUAVLYLlHZZGSHMC+dqRHWJLal0M9UzYZGmENOELDjjDMqjmkW6HvARUuMyBP2iE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781517704; c=relaxed/simple; bh=uMZgz1vTiaRMLNsKsNm0dvHwt9AvmSvZMAwkSMDijAg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M26jZ3kebAitB8uMjshkuq/AvMLJ6qRcedvTgtBb0qp32C6MBmP3p7yXdtkQF4/RPLSgS9InDHBHRvvlO4a8lfcfrT57NuJti7PzWosXxtEvMUXqk2KcVP86eUzCwU0e1Mzz+j1FOC7zqbIga+V70sQbyP1uorklV/h9/I7O3Uw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H/TxuAZi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H/TxuAZi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D83EF1F000E9; Mon, 15 Jun 2026 10:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781517703; bh=5AbWeqS/xKwakGdjqbnfqVp4y0udwwlVR+ZRCrbcWMg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=H/TxuAZinPO4H71+nK3269iPNOuT97g11xD6SDqSrKd7T3fxvRlFJgHlI4Gma1yQV /IYJiZhuXR0LLW1db5XGNfABDZkZCbh02bJjkzAhdBC/wFQKZ5hMtroYD8Wnhp24gu 71b1QHLdRCkyNprqN9ZxqsFFnipGqqVARGdJjt2yMQJiCv5i1oBLvxZRCQWpgx7R0L HUowHP1uxPwScLWaD7ejXYJsITXHuJpM+dl6x1z5uWY9GmEGuZzrVv+OlAWgTghry+ RW1RiJ3Ub64ulmOshHoEtuJc3EYJhRledrDxodS8kEhTft/GYgqYixnRaKiUu+tFRO wlcUW/8WnRa0g== Message-ID: <1c63fbca-6ee4-466f-bfb5-5ff25a847607@kernel.org> Date: Mon, 15 Jun 2026 12:01:38 +0200 Precedence: bulk X-Mailing-List: cgroups@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/16] mm/slab: replace struct partial_context with slab_alloc_context Content-Language: en-US To: Suren Baghdasaryan , Harry Yoo Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org References: <20260610-slab_alloc_flags-v2-0-7190909db118@kernel.org> <20260610-slab_alloc_flags-v2-7-7190909db118@kernel.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/15/26 04:36, Suren Baghdasaryan wrote: > On Wed, Jun 10, 2026 at 11:05 PM Harry Yoo wrote: >> >> >> >> On 6/11/26 12:40 AM, Vlastimil Babka (SUSE) wrote: >> > Refactor get_from_partial_node(), get_from_any_partial(), >> > get_from_partial() and ___slab_alloc(). >> > >> > Remove struct partial_context, which used to be more substantial but >> > shrank as part of the sheaves conversion. Instead pass gfp_flags and >> > pointer to the new slab_alloc_context, which together is a superset of >> > partial_context. >> > >> > This means alloc_flags are now available and we can use them to >> > determine if spinning is allowed, further reducing false positive "not >> > allowed" in the slow path due to gfp flags lacking __GFP_RECLAIM. >> > >> > Signed-off-by: Vlastimil Babka (SUSE) >> > --- >> >> Looks good to me, >> Reviewed-by: Harry Yoo (Oracle) > > Ah, nice! The conversion I was anticipating in the previous patch... > I would do this removal of partial_context as patch 6 and then convert > ___slab_alloc() and get_from_any_partial*() altogether in patch 7. I > think that would keep the behavior of the ___slab_alloc() more robust > throughout the patchset. But I would say it's nice to have, not a > must-have. OK, so I switched the order of 6 7 and all the changes from gfpflags_allow_spinning() to alloc_flags_allow_spinning are now in the newly-later patch; the "replace struct partial_context with slab_alloc_context" part has no functional changes. Verified that the end result is exactly the same, and only updated changelogs a bit. > Reviewed-by: Suren Baghdasaryan Thanks! >> >> -- >> Cheers, >> Harry / Hyeonggon