From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Mandeep Singh Baines <msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Frederic Weisbecker
<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
Subject: Re: [PATCH 5/5] cgroup: separate out cgroup_attach_proc error handling code
Date: Tue, 20 Dec 2011 16:13:47 -0800 [thread overview]
Message-ID: <20111221001347.GQ10752@google.com> (raw)
In-Reply-To: <20111221000231.GX13529-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Tue, Dec 20, 2011 at 04:02:31PM -0800, Mandeep Singh Baines wrote:
> > Hmm... maybe goto out_free_group_list? Duplicating cleanup on success
> > and failure paths can lead future updaters forget one of them. The
> > exit path in this function isn't pretty but I don't think the proposed
> > patch improves it either.
> >
>
> Should I drop the patch or add the goto? Its 5/5 so easy enough to drop
> since nothing else depends on it.
Yeah, let's drop it for now. Thanks.
--
tejun
prev parent reply other threads:[~2011-12-21 0:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1324422873-31001-1-git-send-email-msb@chromium.org>
[not found] ` <1324422873-31001-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:14 ` [PATCH 1/5 V3] cgroup: remove redundate get/put of old css_set from migrate Mandeep Singh Baines
[not found] ` <1324422873-31001-2-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:18 ` Tejun Heo
[not found] ` <20111220231823.GK10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:41 ` Mandeep Singh Baines
[not found] ` <20111220234131.GV13529-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:42 ` Tejun Heo
[not found] ` <20111220234259.GO10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:46 ` Tejun Heo
2011-12-21 1:10 ` Li Zefan
2011-12-20 23:14 ` [PATCH 2/5] cgroup: remove redundant get/put of task struct Mandeep Singh Baines
[not found] ` <1324422873-31001-3-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:23 ` Tejun Heo
[not found] ` <20111220232326.GL10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:04 ` Mandeep Singh Baines
2011-12-20 23:14 ` [PATCH 3/5] cgroup: only need to check oldcgrp==newgrp once Mandeep Singh Baines
[not found] ` <1324422873-31001-4-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-21 1:29 ` Li Zefan
2011-12-20 23:14 ` [PATCH 4/5] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
[not found] ` <1324422873-31001-5-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:30 ` Tejun Heo
[not found] ` <20111220233050.GM10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-20 23:47 ` Mandeep Singh Baines
2011-12-20 23:14 ` [PATCH 5/5] cgroup: separate out cgroup_attach_proc error handling code Mandeep Singh Baines
[not found] ` <1324422873-31001-6-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-20 23:35 ` Tejun Heo
[not found] ` <20111220233502.GN10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:02 ` Mandeep Singh Baines
[not found] ` <20111221000231.GX13529-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-12-21 0:13 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221001347.GQ10752@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).