From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
Mandeep Singh Baines
<msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
Subject: Re: [PATCH 4/4] cgroup: remove extra calls to find_existing_css_set
Date: Thu, 22 Dec 2011 07:40:37 -0800 [thread overview]
Message-ID: <20111222154037.GC17084@google.com> (raw)
In-Reply-To: <20111222094437.GO17668@somewhere>
On Thu, Dec 22, 2011 at 10:44:39AM +0100, Frederic Weisbecker wrote:
> > > if (ent.cgrp == cgrp)
> > > continue;
> > > + ent.cg = find_css_set(tsk->cgroups, cgrp);
> >
> > unfortunately This won't work, because we are holding tasklist_lock.
>
> I believe we can remove tasklist_lock now (in a seperate patch).
>
> It was there in order to protect while_each_thread() against exec but
> now we have threadgroup_lock().
>
> I think we only need to use rcu_read_lock() to protect against concurrent
> removal in exit.
Yeah, that should work and I really like this patch.
kernel/cgroup.c | 152 ++++++++++++-------------------------------------------
1 files changed, 32 insertions(+), 120 deletions(-)
Let's get it working. :)
Thanks.
--
tejun
next prev parent reply other threads:[~2011-12-22 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 4:18 [PATCH 1/4] cgroup: remove redundant get/put of old css_set from migrate Mandeep Singh Baines
[not found] ` <1324527518-24461-1-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-22 4:18 ` [PATCH 2/4] cgroup: remove redundant get/put of task struct Mandeep Singh Baines
[not found] ` <1324527518-24461-2-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-22 5:36 ` Li Zefan
2011-12-22 4:18 ` [PATCH 3/4] cgroup: only need to check oldcgrp==newgrp once Mandeep Singh Baines
[not found] ` <1324527518-24461-3-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-22 15:38 ` Tejun Heo
2011-12-22 4:18 ` [PATCH 4/4] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
[not found] ` <1324527518-24461-4-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2011-12-22 5:50 ` Li Zefan
[not found] ` <4EF2C536.7070408-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-12-22 9:44 ` Frederic Weisbecker
2011-12-22 15:40 ` Tejun Heo [this message]
2011-12-22 5:11 ` [PATCH 1/4] cgroup: remove redundant get/put of old css_set from migrate Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222154037.GC17084@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).