From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [RFD] cgroup: about multiple hierarchies Date: Thu, 23 Feb 2012 15:32:41 -0500 Message-ID: <20120223203241.GJ19691@redhat.com> References: <20120221211938.GE12236@google.com> <20120222163858.GB4128@redhat.com> <4F45F1F0.2010102@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F45F1F0.2010102-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Li Zefan Cc: Frederic Weisbecker , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Kay Sievers , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , Lennart Poettering , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton On Thu, Feb 23, 2012 at 03:59:44PM +0800, Li Zefan wrote: > > Trying to make all the controllers uniform in terms of their treatment > > of cgroup hiearchy sounds like a good thing to do. > > Agreed. > > Apart from nesting cgroups, there're other inconsistencies. > > - Some controllers disallow more than one cgroup layer. That's the new > net_prio controller, and I don't know why it's made so, but I guess > it's fine to eliminate this restriction. You mean don't allow creating deeper levels in cgroup hierarcy? That will fail with libvirt + systemd as they create much deeper levels. I had to change that for blkio. > > - Some controllers move resource charges when a task is moved to > a different cgroup, but some don't? I think in case of some controllers it does not even apply. For cpu, blkio resources are renewable, so there is no moving around of charges. Thanks Vivek