From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH -V3 2/8] memcg: Add HugeTLB extension Date: Tue, 13 Mar 2012 14:33:16 -0700 Message-ID: <20120313143316.0ef74d0e.akpm@linux-foundation.org> References: <1331622432-24683-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1331622432-24683-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331622432-24683-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, mgorman@suse.de, kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com, aarcange@redhat.com, mhocko@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org On Tue, 13 Mar 2012 12:37:06 +0530 "Aneesh Kumar K.V" wrote: > +static int mem_cgroup_hugetlb_usage(struct mem_cgroup *memcg) > +{ > + int idx; > + for (idx = 0; idx < hugetlb_max_hstate; idx++) { > + if (memcg->hugepage[idx].usage > 0) > + return memcg->hugepage[idx].usage; > + } > + return 0; > +} Please document the function? Had you done this, I might have been able to work out why the function bales out on the first used hugepage size, but I can't :( This could have used for_each_hstate(), had that macro been better designed (or updated). Upon return this function coerces an unsigned long long into an "int". We decided last week that more than 2^32 hugepages was not inconceivable, so I guess that's a bug. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org