From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Date: Fri, 11 May 2012 14:17:54 -0700 Message-ID: <20120511141754.e0719c26.akpm@linux-foundation.org> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FACDFAE.5050808-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: KAMEZAWA Hiroyuki Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel On Fri, 11 May 2012 18:45:18 +0900 KAMEZAWA Hiroyuki wrote: > The conditions are handled as -EBUSY, _now_. The changelog is poor. I rewrote it to : hugetlb_force_memcg_empty() incorrectly returns 0 (success) when the : cgroup is found to be busy. Return -EBUSY instead. But it still doesn't tell us the end-user-visible effects of the bug. It should.