From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: Salman Qazi <sqazi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroups: Account for CSS_DEACT_BIAS in __css_put
Date: Mon, 18 Jun 2012 15:39:23 -0700 [thread overview]
Message-ID: <20120618223923.GG32733@google.com> (raw)
In-Reply-To: <4FDAE23C.2020908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Fri, Jun 15, 2012 at 03:20:28PM +0800, Li Zefan wrote:
> On 2012/6/15 5:55, Salman Qazi wrote:
>
> > When we fixed the race between atomic_dec and css_refcnt, we missed
> > the fact that css_refcnt internally subtracts CSS_DEACT_BIAS to get
> > the actual reference count. This can potentially cause a refcount leak
> > if __css_put races with cgroup_clear_css_refs.
> >
> > Signed-off-by: Salman Qazi <sqazi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>
>
> Hope we've got everything right this time!
>
> Acked-by: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Applied to for-3.5-fixes. Thanks.
--
tejun
prev parent reply other threads:[~2012-06-18 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 21:55 [PATCH] cgroups: Account for CSS_DEACT_BIAS in __css_put Salman Qazi
[not found] ` <20120614215530.12092.3543.stgit-Oz2bD8w/QAX+Wsei8lUk51LMcqb5oVE02SarAXORi/o@public.gmane.org>
2012-06-15 7:20 ` Li Zefan
[not found] ` <4FDAE23C.2020908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-06-18 22:39 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618223923.GG32733@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=sqazi-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).