From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH V2] memcg: cleanup typos in mem cgroup Date: Sat, 23 Jun 2012 10:16:01 +0800 Message-ID: <20120623021547.GA2227@kernel> References: <1340369199-29535-1-git-send-email-liwp.linux@gmail.com> <20120622150358.GB16628@tiehlicka.suse.cz> Reply-To: Wanpeng Li Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zHRWNeYx4LUxSVYyUvg/2NZXTKJkevPmDC1QF2sgwvc=; b=P3v6PnDXWLRcM/jC/T+/MLDPn2f4htsGK0BSBNMuzXJGSF8i12Pk3828JUeK5yH8CR mwg4eH94uNGtljw341ig5YODhmtTok89KbY5+qdt0bxSC1fgz1whJoP6u3znpebaL/jx Ozjnb7Vpkd0VgpC6vFm3XQ52ShYrIqKIZJPI+i4XJhbawWqEEv3/87c9BaIbyuZbWQWQ W3ENiPIc/k4j5NJwQSkuiV9m/AG7mOlKO05JmVTyqv0hgr3C23dToPUKaSYwf1H1N+IQ xbF1+ZBH3BHS4lptTQN+p6N/broY9Wl+jGS/2M80yRCGj/SnOvBcE70Kx85n54X2gC5W K5zw== Content-Disposition: inline In-Reply-To: <20120622150358.GB16628@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: "linux-mm@kvack.org" , cgroups@vger.kernel.org, KAMEZAWA Hiroyuki , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel , Wanpeng Li On Fri, Jun 22, 2012 at 05:03:59PM +0200, Michal Hocko wrote: >Have you used any tool to find those typos? Have you gone through the >whole memcontrol.c file? >I am not agains fixes like this but I would much prefer if it was one >batch of all fixes. I bet there are more typose ;) OK, I will figure out them and resend the patch. Regards, Wanpeng Li > >On Fri 22-06-12 20:46:39, Wanpeng Li wrote: >> From: Wanpeng Li >> >> Signed-off-by: Wanpeng Li >> --- >> mm/memcontrol.c | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 776fc57..503ddd0 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -115,8 +115,8 @@ static const char * const mem_cgroup_events_names[] = { >> >> /* >> * Per memcg event counter is incremented at every pagein/pageout. With THP, >> - * it will be incremated by the number of pages. This counter is used for >> - * for trigger some periodic events. This is straightforward and better >> + * it will be incremented by the number of pages. This counter is used to >> + * trigger some periodic events. This is straightforward and better >> * than using jiffies etc. to handle periodic memcg event. >> */ >> enum mem_cgroup_events_target { >> @@ -678,7 +678,7 @@ mem_cgroup_largest_soft_limit_node(struct mem_cgroup_tree_per_zone *mctz) >> * >> * If there are kernel internal actions which can make use of some not-exact >> * value, and reading all cpu value can be performance bottleneck in some >> - * common workload, threashold and synchonization as vmstat[] should be >> + * common workload, threshold and synchonization as vmstat[] should be >> * implemented. >> */ >> static long mem_cgroup_read_stat(struct mem_cgroup *memcg, >> @@ -2213,7 +2213,6 @@ static int mem_cgroup_do_charge(struct mem_cgroup *memcg, gfp_t gfp_mask, >> if (mem_cgroup_wait_acct_move(mem_over_limit)) >> return CHARGE_RETRY; >> >> - /* If we don't need to call oom-killer at el, return immediately */ >> if (!oom_check) >> return CHARGE_NOMEM; >> /* check OOM */ >> @@ -2291,7 +2290,7 @@ again: >> * In that case, "memcg" can point to root or p can be NULL with >> * race with swapoff. Then, we have small risk of mis-accouning. >> * But such kind of mis-account by race always happens because >> - * we don't have cgroup_mutex(). It's overkill and we allo that >> + * we don't have cgroup_mutex(). It's overkill and we allow that >> * small race, here. >> * (*) swapoff at el will charge against mm-struct not against >> * task-struct. So, mm->owner can be NULL. >> @@ -2396,7 +2395,7 @@ static void __mem_cgroup_cancel_charge(struct mem_cgroup *memcg, >> } >> >> /* >> - * Cancel chrages in this cgroup....doesn't propagate to parent cgroup. >> + * Cancel charges in this cgroup....doesn't propagate to parent cgroup. >> * This is useful when moving usage to parent cgroup. >> */ >> static void __mem_cgroup_cancel_local_charge(struct mem_cgroup *memcg, >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org > >-- >Michal Hocko >SUSE Labs >SUSE LINUX s.r.o. >Lihovarska 1060/12 >190 00 Praha 9 >Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org