From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH] mm/memcg: add BUG() to mem_cgroup_reset Date: Fri, 6 Jul 2012 10:22:42 +0200 Message-ID: <20120706082242.GA1230@cmpxchg.org> References: <1341546297-6223-1-git-send-email-liwp.linux@gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <1341546297-6223-1-git-send-email-liwp.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wanpeng Li Cc: Andrew Morton , Michal Hocko , KAMEZAWA Hiroyuki , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, Jul 06, 2012 at 11:44:57AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Branch in mem_cgroup_reset only can be RES_MAX_USAGE, RES_FAILCNT. And nobody is passing anything else. Which is easy to prove as this is a private function. And there wouldn't even be any harm passing something else. Please don't add stuff like this.