From: Tejun Heo <htejun@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Michal Hocko <mhocko@suse.cz>,
akpm@linux-foundation.org, mm-commits@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com, liwanp@linux.vnet.ibm.com,
Li Zefan <lizefan@huawei.com>,
cgroups mailinglist <cgroups@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: + hugetlb-cgroup-simplify-pre_destroy-callback.patch added to -mm tree
Date: Fri, 20 Jul 2012 12:56:43 -0700 [thread overview]
Message-ID: <20120720195643.GC21218@google.com> (raw)
In-Reply-To: <87d33qmeb9.fsf@skywalker.in.ibm.com>
On Sat, Jul 21, 2012 at 12:48:34AM +0530, Aneesh Kumar K.V wrote:
> Does cgroup_rmdir do a cgroup_task_count check ? I do see that it check
> cgroup->childern and cgroup->count. But cgroup->count is not same as
> task_count right ?
>
> May be we need to push the task_count check also to rmdir so that
> pre_destory doesn't need to check this
task_count implies cgroup refcnt which cgroup core does check. No
need to worry about that, ->children or whatever from memcg. As soon
as the deprecated behavior is gone, everything will be okay;
otherwise, it's a bug in cgroup core.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-07-20 19:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120718212637.133475C0050@hpza9.eem.corp.google.com>
[not found] ` <20120718212637.133475C0050-gd0R4GGuC+lfGOtoag0VdhPsWskHk0ljAL8bYrjMMd8@public.gmane.org>
2012-07-19 11:39 ` + hugetlb-cgroup-simplify-pre_destroy-callback.patch added to -mm tree Michal Hocko
2012-07-19 12:21 ` Aneesh Kumar K.V
[not found] ` <87r4s8gcwe.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-07-19 12:38 ` Michal Hocko
[not found] ` <20120719123820.GG2864-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-07-19 13:48 ` Aneesh Kumar K.V
[not found] ` <87ipdjc15j.fsf-6yE53ggjAfyqSkle7U1LjlaTQe2KTcn/@public.gmane.org>
2012-07-19 14:09 ` [PATCH] cgroup: Don't drop the cgroup_mutex in cgroup_rmdir Aneesh Kumar K.V
[not found] ` <1342706972-10912-1-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-07-19 16:50 ` Tejun Heo
2012-07-20 15:45 ` Peter Zijlstra
2012-07-20 20:05 ` Tejun Heo
2012-07-20 22:07 ` Glauber Costa
[not found] ` <20120720200542.GD21218-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-07-27 6:15 ` Li Zefan
[not found] ` <501231F0.8050505-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-07-30 18:25 ` Tejun Heo
2012-07-20 7:51 ` Michal Hocko
2012-07-20 19:49 ` Tejun Heo
2012-07-20 1:05 ` + hugetlb-cgroup-simplify-pre_destroy-callback.patch added to -mm tree Kamezawa Hiroyuki
[not found] ` <5008AEC2.9090707-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-20 1:20 ` Kamezawa Hiroyuki
[not found] ` <5008B25D.5000902-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-20 8:01 ` Michal Hocko
2012-07-20 8:08 ` Kamezawa Hiroyuki
2012-07-20 8:06 ` Michal Hocko
2012-07-20 19:18 ` Aneesh Kumar K.V
2012-07-20 19:56 ` Tejun Heo [this message]
[not found] ` <20120720195643.GC21218-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-07-21 2:14 ` Kamezawa Hiroyuki
2012-07-21 2:46 ` Tejun Heo
2012-07-21 4:05 ` Kamezawa Hiroyuki
[not found] ` <500A2A79.5030705-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-07-22 17:34 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720195643.GC21218@google.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).