Re: [PATCH 0/4] device_cgroup: replace internally whitelist with exception list

[Aristeu Rozanski <aris-moeOTchvdi7YtjvyW6yDsg@public.gmane.org>]

On Tue, Jul 24, 2012 at 06:03:33PM -0400, Aristeu Rozanski wrote:
> The original model of device_cgroup is having a whitelist where all the
> allowed devices are listed. The problem with this approach is that is
> impossible to have the case of allowing everything but few devices.
> 
> The reason for that lies in the way the whitelist is handled internally:
> since there's only a whitelist, the "all devices" entry would have to be
> removed and replaced by the entire list of possible devices but the ones
> that are being denied.  Since dev_t is 32 bits long, representing the allowed
> devices as a bitfield is not memory efficient.
> 
> This patch replaces the "whitelist" by a "exceptions" list and the default
> policy is kept as "deny_all" variable in dev_cgroup structure.

Any comments on these patches?

-- 
Aristeu