From: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: aris-moeOTchvdi7YtjvyW6yDsg@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH RESEND 0/4] device_cgroup: replace internally whitelist with exception list
Date: Thu, 16 Aug 2012 13:08:44 -0700 [thread overview]
Message-ID: <20120816130844.6f26530d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120809190414.773462171-+5JutNtNrJPwzbzh4h2Q61C45dnP8DBc@public.gmane.org>
On Thu, 09 Aug 2012 15:04:14 -0400
aris-moeOTchvdi7YtjvyW6yDsg@public.gmane.org wrote:
> The original model of device_cgroup is having a whitelist where all the
> allowed devices are listed. The problem with this approach is that is
> impossible to have the case of allowing everything but few devices.
>
> The reason for that lies in the way the whitelist is handled internally:
> since there's only a whitelist, the "all devices" entry would have to be
> removed and replaced by the entire list of possible devices but the ones
> that are being denied. Since dev_t is 32 bits long, representing the allowed
> devices as a bitfield is not memory efficient.
>
> This patch replaces the "whitelist" by a "exceptions" list and the default
> policy is kept as "deny_all" variable in dev_cgroup structure.
The patches look reasonable to me. I suggest you resend them after
kernel summit and cc a few additional people: Serge Hallyn, Pavel
Emelyanov and James Morris.
next prev parent reply other threads:[~2012-08-16 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 19:04 [PATCH RESEND 0/4] device_cgroup: replace internally whitelist with exception list aris-moeOTchvdi7YtjvyW6yDsg
2012-08-09 19:04 ` [PATCH RESEND 1/4] device_cgroup: add "deny_all" in dev_cgroup structure aris
2012-08-09 19:04 ` [PATCH RESEND 2/4] device_cgroup: introduce dev_whitelist_clean() aris
2012-08-09 19:04 ` [PATCH RESEND 3/4] device_cgroup: convert device_cgroup internally to policy + exceptions aris-moeOTchvdi7YtjvyW6yDsg
2012-08-09 19:04 ` [PATCH RESEND 4/4] device_cgroup: rename whitelist to exception list aris
[not found] ` <20120809190414.773462171-+5JutNtNrJPwzbzh4h2Q61C45dnP8DBc@public.gmane.org>
2012-08-16 20:08 ` Andrew Morton [this message]
[not found] ` <20120816130844.6f26530d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-08-16 20:49 ` [PATCH RESEND 0/4] device_cgroup: replace internally whitelist with " Aristeu Rozanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816130844.6f26530d.akpm@linux-foundation.org \
--to=akpm-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=aris-moeOTchvdi7YtjvyW6yDsg@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox