cgroups.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Cc: Joseph Glanville
	<joseph.glanville-2MxvZkOi9dvvnOemgxGiVw@public.gmane.org>,
	cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 2/2] block: fix request_queue->flags initialization
Date: Thu, 20 Sep 2012 14:09:30 -0700	[thread overview]
Message-ID: <20120920210930.GD7264@google.com> (raw)
In-Reply-To: <20120920210852.GC7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

A queue newly allocated with blk_alloc_queue_node() has only
QUEUE_FLAG_BYPASS set.  For request-based drivers,
blk_init_allocated_queue() is called and q->queue_flags is overwritten
with QUEUE_FLAG_DEFAULT which doesn't include BYPASS even though the
initial bypass is still in effect.

In blk_init_allocated_queue(), or QUEUE_FLAG_DEFAULT to q->queue_flags
instead of overwriting.

Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
---
 block/blk-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -696,7 +696,7 @@ blk_init_allocated_queue(struct request_
 	q->request_fn		= rfn;
 	q->prep_rq_fn		= NULL;
 	q->unprep_rq_fn		= NULL;
-	q->queue_flags		= QUEUE_FLAG_DEFAULT;
+	q->queue_flags		|= QUEUE_FLAG_DEFAULT;
 
 	/* Override internal queue lock with supplied lock pointer */
 	if (lock)

  parent reply	other threads:[~2012-09-20 21:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-16 17:31 3.6-rc5 cgroups blkio throttle + md regression Joseph Glanville
     [not found] ` <CAOzFzEhf2LfT0BCNPAgPgxZ3=pj2KvJ4Z6kP7XF8nnxag1dfvg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-19 16:28   ` Joseph Glanville
     [not found]     ` <CAOzFzEiC4313K4H9393ffzNyBo398BPYSxTk7ZEmuH4GfW5qtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-19 18:20       ` Joseph Glanville
     [not found]         ` <CAOzFzEhWk_7oQFOyW6Ri_9Cvsshj2s3pa=Oo-p8uL6r340MoTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-19 19:42           ` Vivek Goyal
     [not found]             ` <20120919194231.GF31860-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-20 18:31               ` Tejun Heo
     [not found]                 ` <20120920183153.GI28934-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-20 18:42                   ` Vivek Goyal
     [not found]                     ` <20120920184219.GH4681-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-20 19:17                       ` Vivek Goyal
     [not found]                         ` <20120920191716.GI4681-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-20 19:20                           ` Tejun Heo
     [not found]                             ` <20120920192038.GJ28934-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-20 19:32                               ` Vivek Goyal
     [not found]                                 ` <20120920193227.GJ4681-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-20 20:17                                   ` Tejun Heo
2012-09-20 19:57                               ` Vivek Goyal
     [not found]                                 ` <20120920195759.GK4681-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-20 20:18                                   ` Tejun Heo
     [not found]                                     ` <20120920201815.GB7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-20 21:08                                       ` [PATCH 1/2] block: lift the initial queue bypass mode on blk_register_queue() instead of blk_init_allocated_queue() Tejun Heo
     [not found]                                         ` <20120920210852.GC7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-20 21:09                                           ` Tejun Heo [this message]
     [not found]                                             ` <20120920210930.GD7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-21 13:25                                               ` [PATCH 2/2] block: fix request_queue->flags initialization Vivek Goyal
2012-09-21 13:25                                           ` [PATCH 1/2] block: lift the initial queue bypass mode on blk_register_queue() instead of blk_init_allocated_queue() Vivek Goyal
2012-09-21 13:25                                           ` Jens Axboe
     [not found]                                             ` <505C6AD4.6030206-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2012-10-16 10:00                                               ` Joseph Glanville
     [not found]                                                 ` <CAOzFzEiCWazLEfjo=w8c+7qCce98Q6faW1uwGm-tRmCNPJUztw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-16 19:11                                                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120920210930.GD7264@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=joseph.glanville-2MxvZkOi9dvvnOemgxGiVw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).