From: Tejun Heo <tj@kernel.org>
To: Pekka Enberg <penberg@kernel.org>
Cc: Glauber Costa <glommer@parallels.com>,
Christoph Lameter <cl@linux.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org,
linux-mm@kvack.org, Suleiman Souhlal <suleiman@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mel Gorman <mgorman@suse.de>,
David Rientjes <rientjes@google.com>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3 09/16] sl[au]b: always get the cache from its page in kfree
Date: Fri, 21 Sep 2012 13:16:02 -0700 [thread overview]
Message-ID: <20120921201602.GN7264@google.com> (raw)
In-Reply-To: <CAOJsxLFgK3=Eu1UQt8NOSe30824UcuxZftxD1xnpkOt3MepOVg@mail.gmail.com>
On Fri, Sep 21, 2012 at 11:14:45PM +0300, Pekka Enberg wrote:
> On Fri, Sep 21, 2012 at 11:07 PM, Tejun Heo <tj@kernel.org> wrote:
> > Not necessarily disagreeing, but I don't think it's helpful to set the
> > bar impossibly high. Even static_key doesn't have "exactly *zero*"
> > impact. Let's stick to as minimal as possible when not in use and
> > reasonable in use.
>
> For !CONFIG_MEMCG_KMEM, it should be exactly zero. No need to play
> games with static_key.
Ah, misread, though you were talking about MEMCG_KMEM && not in use.
Yeap, if turned off in Kconfig, it shouldn't have any performance
overhead.
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-21 20:16 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:11 [PATCH v3 00/16] slab accounting for memcg Glauber Costa
[not found] ` <1347977530-29755-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-18 14:11 ` [PATCH v3 01/16] slab/slub: struct memcg_params Glauber Costa
2012-09-18 14:11 ` [PATCH v3 02/16] slub: use free_page instead of put_page for freeing kmalloc allocation Glauber Costa
2012-09-18 14:11 ` [PATCH v3 03/16] slab: Ignore the cflgs bit in cache creation Glauber Costa
2012-09-18 15:20 ` Christoph Lameter
[not found] ` <1347977530-29755-4-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-21 17:33 ` Tejun Heo
2012-09-18 14:11 ` [PATCH v3 04/16] provide a common place for initcall processing in kmem_cache Glauber Costa
[not found] ` <1347977530-29755-5-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-18 15:22 ` Christoph Lameter
2012-09-18 14:11 ` [PATCH v3 05/16] consider a memcg parameter in kmem_create_cache Glauber Costa
2012-09-21 18:14 ` Tejun Heo
[not found] ` <20120921181458.GG7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-24 8:12 ` Glauber Costa
[not found] ` <506015E7.8030900-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 12:41 ` Christoph
2012-09-24 12:41 ` Glauber Costa
[not found] ` <50605500.5050606-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 13:42 ` Christoph Lameter
2012-09-24 13:44 ` Glauber Costa
[not found] ` <506063B8.70305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 13:56 ` Christoph Lameter
2012-09-24 13:57 ` Glauber Costa
[not found] ` <506066E3.6050705-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 15:38 ` Pekka Enberg
2012-09-24 15:36 ` Glauber Costa
2012-09-24 17:38 ` Christoph Lameter
[not found] ` <CAOJsxLGFWQFNUUN3sDeB2sn0S-QM-6Ut_d02HjmF6mB5aMytoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-24 17:39 ` Christoph Lameter
2012-10-02 14:46 ` Michal Hocko
2012-09-18 14:12 ` [PATCH v3 06/16] memcg: infrastructure to match an allocation to the right cache Glauber Costa
2012-09-21 18:32 ` Tejun Heo
2012-09-24 8:46 ` Glauber Costa
2012-09-24 17:56 ` Tejun Heo
[not found] ` <20120924175619.GD7694-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-25 13:57 ` Glauber Costa
2012-09-25 16:28 ` Christoph Lameter
2012-09-21 20:52 ` Tejun Heo
[not found] ` <20120921205236.GT7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-24 8:17 ` Glauber Costa
[not found] ` <50601721.6040805-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 17:58 ` Tejun Heo
2012-09-18 14:12 ` [PATCH v3 07/16] memcg: skip memcg kmem allocations in specified code regions Glauber Costa
2012-09-21 19:59 ` Tejun Heo
[not found] ` <20120921195929.GL7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-24 9:09 ` Glauber Costa
[not found] ` <50602343.6040806-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 17:47 ` Tejun Heo
2012-09-18 14:12 ` [PATCH v3 08/16] slab: allow enable_cpu_cache to use preset values for its tunables Glauber Costa
[not found] ` <1347977530-29755-9-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-18 15:25 ` Christoph Lameter
[not found] ` <00000139d9fc4ccc-d0904b9b-5bbf-4cf6-9325-013f16f11745-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-09-19 7:44 ` Glauber Costa
2012-09-21 9:29 ` Pekka Enberg
2012-09-18 14:12 ` [PATCH v3 09/16] sl[au]b: always get the cache from its page in kfree Glauber Costa
[not found] ` <1347977530-29755-10-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-18 15:28 ` Christoph Lameter
2012-09-19 7:42 ` Glauber Costa
2012-09-19 14:14 ` Christoph Lameter
2012-09-21 9:33 ` Pekka Enberg
2012-09-21 9:30 ` Glauber Costa
2012-09-21 9:41 ` Pekka Enberg
[not found] ` <alpine.LFD.2.02.1209211240410.3619-XMdqyYT0w3YmYvmMESoHnA@public.gmane.org>
2012-09-21 20:07 ` Tejun Heo
[not found] ` <20120921200733.GM7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-21 20:14 ` Pekka Enberg
2012-09-21 20:16 ` Tejun Heo [this message]
2012-09-18 14:12 ` [PATCH v3 10/16] sl[au]b: Allocate objects from memcg cache Glauber Costa
2012-09-18 14:12 ` [PATCH v3 11/16] memcg: destroy memcg caches Glauber Costa
2012-09-21 20:22 ` Tejun Heo
2012-09-18 14:12 ` [PATCH v3 12/16] memcg/sl[au]b Track all the memcg children of a kmem_cache Glauber Costa
2012-09-21 20:31 ` Tejun Heo
2012-09-18 14:12 ` [PATCH v3 13/16] slab: slab-specific propagation changes Glauber Costa
2012-09-18 17:00 ` Christoph Lameter
[not found] ` <00000139da52bc21-06113921-5cf5-42b6-94e3-fe9763e909bc-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-09-19 7:41 ` Glauber Costa
2012-09-18 14:12 ` [PATCH v3 14/16] slub: slub-specific " Glauber Costa
2012-09-18 14:12 ` [PATCH v3 15/16] memcg/sl[au]b: shrink dead caches Glauber Costa
[not found] ` <1347977530-29755-16-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-18 17:02 ` Christoph Lameter
[not found] ` <00000139da54937f-8f4add94-b203-4a6c-b99a-adc81d443b71-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2012-09-19 7:40 ` Glauber Costa
2012-09-21 4:48 ` JoonSoo Kim
[not found] ` <CAAmzW4NyK6gqqXHttUE35=-=h0Eve-smiYJCj3i+mHFFysQE4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-21 8:40 ` Glauber Costa
2012-09-21 9:28 ` JoonSoo Kim
[not found] ` <CAAmzW4PRPBgySUpNsj=RP6VR3KLcVWv3G7rRtX=r+wiWUTDchw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-21 9:31 ` Glauber Costa
2012-09-21 20:40 ` Tejun Heo
[not found] ` <20120921204035.GQ7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-24 8:25 ` Glauber Costa
[not found] ` <506018DC.2020907-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-24 17:43 ` Tejun Heo
2012-09-21 9:40 ` [PATCH v3 00/16] slab accounting for memcg Pekka Enberg
2012-09-21 9:43 ` Glauber Costa
2012-09-21 20:46 ` Tejun Heo
2012-09-21 20:47 ` Tejun Heo
[not found] ` <20120921204619.GR7264-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-24 8:15 ` Glauber Costa
2012-09-18 14:12 ` [PATCH v3 16/16] Add documentation about the kmem controller Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921201602.GN7264@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=fweisbec@gmail.com \
--cc=glommer@parallels.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=suleiman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).