From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 8/8] cgroup: make ->pre_destroy() return void Date: Wed, 31 Oct 2012 09:57:22 -0400 Message-ID: <20121031135722.GB1865@redhat.com> References: <1351657365-25055-1-git-send-email-tj@kernel.org> <1351657365-25055-9-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1351657365-25055-9-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mhocko-AlSwsSmVLrQ@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On Tue, Oct 30, 2012 at 09:22:45PM -0700, Tejun Heo wrote: > All ->pre_destory() implementations return 0 now, which is the only > allowed return value. Make it return void. > > Signed-off-by: Tejun Heo > Cc: Michal Hocko > Cc: Balbir Singh > Cc: KAMEZAWA Hiroyuki > Cc: Vivek Goyal > --- > block/blk-cgroup.c | 3 +-- > include/linux/cgroup.h | 2 +- > kernel/cgroup.c | 2 +- > mm/hugetlb_cgroup.c | 4 +--- > mm/memcontrol.c | 3 +-- > 5 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c > index f3b44a6..a7816f3 100644 > --- a/block/blk-cgroup.c > +++ b/block/blk-cgroup.c > @@ -600,7 +600,7 @@ struct cftype blkcg_files[] = { > * > * This is the blkcg counterpart of ioc_release_fn(). > */ > -static int blkcg_pre_destroy(struct cgroup *cgroup) > +static void blkcg_pre_destroy(struct cgroup *cgroup) > { > struct blkcg *blkcg = cgroup_to_blkcg(cgroup); > > @@ -622,7 +622,6 @@ static int blkcg_pre_destroy(struct cgroup *cgroup) > } > > spin_unlock_irq(&blkcg->lock); > - return 0; Looks good from blk-cgroup perspective. ACK for these bits. Thanks Vivek