From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Hocko Subject: Re: [PATCH 1/8] cgroup: kill cgroup_subsys->__DEPRECATED_clear_css_refs Date: Wed, 31 Oct 2012 21:12:27 +0100 Message-ID: <20121031201227.GF1271@dhcp22.suse.cz> References: <1351712650-23709-1-git-send-email-tj@kernel.org> <1351712650-23709-2-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1351712650-23709-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org On Wed 31-10-12 12:44:03, Tejun Heo wrote: > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 7981850..8c605e2 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -865,11 +865,8 @@ static int cgroup_call_pre_destroy(struct cgroup *cgrp) > continue; > > ret = ss->pre_destroy(cgrp); > - if (ret) { > - /* ->pre_destroy() failure is being deprecated */ > - WARN_ON_ONCE(!ss->__DEPRECATED_clear_css_refs); > + if (WARN_ON_ONCE(ret)) > break; > - } > } > > return ret; And sorry for being to annoying about this WARN_ON_ONCE but I really don't see any reason for it. pre_destroy can still happen and now it is even reduced to a reasonable condition (somebody shown up). So I would put it out of way as it doesn't give us anything and as I've already mentioned one can trigger it really easily. -- Michal Hocko SUSE Labs