From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vivek Goyal Subject: Re: [PATCH 09/12] cfq-iosched: enable full blkcg hierarchy support Date: Tue, 18 Dec 2012 14:16:45 -0500 Message-ID: <20121218191645.GA25908@redhat.com> References: <1355524885-22719-1-git-send-email-tj@kernel.org> <1355524885-22719-10-git-send-email-tj@kernel.org> <20121218184022.GC24050@redhat.com> <20121218191055.GN1844@htj.dyndns.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20121218191055.GN1844-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ctalbott-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, rni-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org On Tue, Dec 18, 2012 at 11:10:55AM -0800, Tejun Heo wrote: > Hey, Vivek. > > On Tue, Dec 18, 2012 at 01:40:23PM -0500, Vivek Goyal wrote: > > Can we update Documentation/blkio-controller.txt file to explain all > > this. Also it would be nice to also explain the case of a group having > > both tasks and groups as child and then how shares will be calculated. > > There we can also explain the notion of group->weight and > > group->leaf_weight. > > Yeah, sure thing. Other than documentation / field names, do things > look okay to you? If so, I'll post updated round once -rc1 happens. Hi Tejun, Yes, in general things look good to me with this patch. /me is wondering how to get a response from cpu controller folks. Thanks Vivek