Linux cgroups development
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Jeff Liu <jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] cgroup: don't show pid list on tasks/procs in ascending order
Date: Tue, 15 Jan 2013 00:34:12 -0600	[thread overview]
Message-ID: <20130115063412.GA25338@sergelap> (raw)
In-Reply-To: <50F4F76D.2050409-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Quoting Jeff Liu (jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org):
> On 01/15/2013 02:25 PM, Serge Hallyn wrote:
> > Quoting Jeff Liu (jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org):
> >> Hello,
> >>
> >> Currently, the pid list shown on cgroup->procs & tasks is in ascending order.  However, this list is not
> >> guaranteed to be sorted according to the following records mentioned at Documentation/cgroups/cgroups.txt.
> >>
> >>  - tasks: list of tasks (by PID) attached to that cgroup.  This list
> >>    is not guaranteed to be sorted. 
> >>  - cgroup.procs: list of thread group IDs in the cgroup.  This list is
> >>    not guaranteed to be sorted or free of duplicate TGIDs, and userspace
> >>    should sort/uniquify the list if this property is required.
> >>
> >> This patch remove the sorting function to make the default behavior of pid list be consistent with
> >> the document.

...

I've gotta say, as someone who tends to play with those files by hand, I
don't mind not having to type | sort | uniq every time.

-serge

  parent reply	other threads:[~2013-01-15  6:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  5:28 [PATCH] cgroup: don't show pid list on tasks/procs in ascending order Jeff Liu
     [not found] ` <50F4E902.20202-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-01-15  6:23   ` Jeff Liu
2013-01-15  6:25   ` Serge Hallyn
2013-01-15  6:30     ` Jeff Liu
     [not found]       ` <50F4F76D.2050409-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-01-15  6:34         ` Serge Hallyn [this message]
2013-01-15  6:56           ` Jeff Liu
     [not found]             ` <50F4FD99.7070406-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2013-01-15 14:08               ` Serge Hallyn
2013-01-15 15:43                 ` Tejun Heo
     [not found]                   ` <20130115154332.GA2598-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2013-01-15 16:14                     ` Serge E. Hallyn
     [not found]                       ` <20130115161420.GA6885-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2013-01-15 16:17                         ` Tejun Heo
2013-01-16  1:50                     ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130115063412.GA25338@sergelap \
    --to=serge.hallyn-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=jeff.liu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox